build: manual usage of semgrep instead of github-actions #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ali-D-Akbar
reviewed
Jul 1, 2022
| @@ -16,6 +16,7 @@ pytest-django | |||
| pytest-responses | |||
| pytest-xdist | |||
| responses | |||
| semgrep | |||
There was a problem hiding this comment.
It doesn't seem like this package added anything while running the upgrade, did it?
There was a problem hiding this comment.
It did, in local.txt. The requirement files' structure for discovery is a weird one. There is no test.txt. Instead, test.in is added in local.in.
|
I'm not sure why you didn't need to make the pylint fixes that I made in #3505, but these tests are passing, so 👍 |
nedbat
approved these changes
Jul 1, 2022
AliAdnanSohail
approved these changes
Jul 1, 2022
DawoudSheraz
force-pushed
the
semgrep-fix-attempt
branch
from
1d8f3e8
to
6632b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-2876
Description
Use semgrep manually instead of GitHub action. This allows using the latest version of semgrep that will potentially fix semgrep issues on various PRs. Base PR: Run semgrep ourselves, not from an action #3505
With selenium 4.3.0, find_elements_by_* methods have been removed. [py]: remove deprecated
find_element_by_methods SeleniumHQ/selenium#10712. The correct method to use is find_element/find_elements where the first argument is search criteria (id, xpath, css selector, etc.). https://selenium-python.readthedocs.io/locating-elements.html