Fix datetime serialization in extras and fix missing bcrypt
#3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibaudDauce
force-pushed
the
fix_datetime_in_extras
branch
from
ee13e14
to
b1a2da3
Compare
ThibaudDauce
force-pushed
the
fix_datetime_in_extras
branch
from
70b1c54
to
388f951
Compare
ThibaudDauce
changed the title
datetime serialization in extrasdatetime serialization in extras and fix missing bcrypt
maudetes
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://errors.data.gouv.fr/organizations/sentry/issues/138221
I'm not sure if the
UDataJsonEncoderis used… Because in my first tests based on Python 3.9, a timestamp was returned. With Python 3.11 (maybe following some dependencies removal too…), Flask RestX is not usingujsonanymore but simplejsonand the serialization changed…If
ujsonis installed, Flask RestX is using it (as in the CI here) so theclsconfig doesn't exists ultrajson/ultrajson#124 but on a fresh install,ujsonis not installed (as in demo.data.gouv.fr) so it's not working…