Feature/add-number-per-pages

[etienneburdet]

Summary

The goal for this PR is to add page size options to pagination.

(Internal for Opendatasoft only) Associated Shortcut ticket: sc-46253. (same as base pr

Changes

The biggest change is that I removed all kind of internal state for the current page or the current number per page. This proves impractical when you add number per pages, leading to having to track the current page in the app on top of the SDK component itself. So now the current page and the current number per page are fully controlled and determined by a single prop.

The select is a native select too. We currently don't support children/slots, so it's possible to use a platform select or something like that. But a native select should be fine for the use.

Options have both a label and a value because we may want to add extra wording (e.g. "5 / page") or other labelling ("small", "large" etc.)

Review checklist

• Description is complete
• Commits respect the Conventional Commits Specification
• 2 reviewers (1 if trivial)
• Tests coverage has improved
• Code is ready for a release on NPM

[github-actions]

Coverage after merging feature/add-number-per-pages into feature/sc-46253/sdk-table-pagination

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

[github-actions]

Coverage after merging feature/add-number-per-pages into feature/sc-46253/sdk-table-pagination

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

[github-actions]

Coverage after merging feature/add-number-per-pages into feature/sc-46253/sdk-table-pagination

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

[github-actions]

Coverage after merging feature/add-number-per-pages into feature/sc-46253/sdk-table-pagination

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

[KevinFabre-ods]

At first sight, everything looks good.

Expect a diff in a Chromatic snapshot that, IMO, should not be there.

I'll let @cybervinvin do the functional review as he implementing the table in the platform

[KevinFabre-ods]

Works fine.

Maybe we could take some times to discuss how each other see if the table should prevent fail behaviors from its events

[KevinFabre-ods]

Let's merge!