Feature/sc-46253/sdk-table-pagination #229

etienneburdet · 2024-03-20T07:43:07Z

Summary

The goal for this PR is to pagination to the table component

(Internal for Opendatasoft only) Associated Shortcut ticket: sc-46253.

Changes

I added a pagination block with options to be styled. It should be disabled when hitting the lower bounds, show ellipsis when there are too much pages and accept an async callbacks.

Stories should reflect all those changes.

I left out the "number per pages". Although the component is here, the way we handle the callback isn't that easy (or actually doesn't really fit with the way we handle the change page callback).

Changelog

"Tables now support paginitaion"

Open discussion

So I stick mostly with our current way of styling, but I think we leverage the new implementation better, by using a "className" props that we can now pass safely. It would avoid wrapping and probably reduce a bit of internal wrapping too.

We can't leverage ods-visualizations-table though (as I initialy hope we could), since it's only present in the react implem for now.

Review checklist

Description is complete
Commits respect the Conventional Commits Specification
2 reviewers (1 if trivial)
Tests coverage has improved
Code is ready for a release on NPM

etienneburdet · 2024-03-21T11:53:42Z

@cybervinvin @KevinFabre-ods Don't mind the style/css too much in this one, I proposed something different in #230 .

KevinFabre-ods

Left some comments about the table behavior with the pagination.

For the eslint changes, what did you encounter to make theses edits ?

Other than that, pagination works well. Maybe we want the current page to react to a change in the API (when initial changes)

packages/visualizations/.eslintrc.js

packages/visualizations-react/package.json

packages/visualizations-react/stories/Table/config.ts

packages/visualizations-react/stories/Table/Pagination.stories.tsx

KevinFabre-ods · 2024-03-26T09:40:24Z

packages/visualizations/src/components/Table/Table.svelte

+    /* Preserves paginations controls positioning
+    min heigh of table + controls = max-height of row * (number of rows + 1 for headers)
+    */
+    $: minHeight = pages ? `${MAX_ROW_HEIGHT * (pages.recordsPerPage + 1)}px` : 'none';


Did we check with the design for this behavior ?
Can be weird if we display 20 items per page with only one item for the last page. We get a lot of white space

No we still have to submit that to Meg, but it's really annoying to have the pagination moving between pages too.

We asked the question https://app.shortcut.com/opendatasoft/story/49140/design-how-the-table-and-pagination-react-when-number-of-items-changes-between-two-pages. Waiting for an answer...

In the meantime, I'm in favor of adding the less code possible. I prefer to add a function or behavior later rather than delete one.

packages/visualizations/src/components/Table/Pagination/Button.svelte

packages/visualizations/src/components/Table/Pagination/Pagination.svelte

KevinFabre-ods · 2024-03-26T10:51:58Z

packages/visualizations/src/components/Table/Table.svelte

-                <Body {records} {columns} />
-            {/if}
-        </table>
+    <div class="table-controls" style="--min-height: {minHeight}">


What is the role of this new div ?

Looks like we have a visual bug on the right of the table. Table rows don't take all the available space

It's for holding the pagination in the same place relative to the table. I think it's fixed in #230

KevinFabre-ods

Some comments about how pagination numbers are computed

packages/visualizations/src/components/Table/Pagination/Pagination.svelte

github-actions · 2024-03-28T17:22:54Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

95.24%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	75.32%	100%	96.88%	124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

etienneburdet · 2024-03-28T17:23:04Z

Sorry the eslint thing got a bit bigger than I thought and ideally should be for this PR… but well, at least it's done.

github-actions · 2024-03-29T10:11:05Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

95.24%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	75.32%	100%	96.88%	124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

etienneburdet · 2024-03-29T10:15:10Z

Soooo… I ended up removing our customization of object-curly-new-lines, because it was conflicting with prettier. The problem appeared of this line:
$: ({ columns, title, subtitle, description, source, unstyled, locale, pagination } = options);
Which has the particularity of never having a default, nor a param assing (e.g. colmuns: options.cols), in which case prettier prefers one line. It never happened before in the codebase.

Now just removing the eslint for curly new line works: what we did before is still good with prettier (because of the = and :). Overall it just lets prettier decides, which is more consistent with the VScode extension I guess.

Prettier still won't let us do something like:

    $: ({
        shapes, colorScale = DEFAULT_COLORSCALE, legend,
        aspectRatio,
        activeShapes,
        interactive = defaultInteractive,
        emptyValueColor = DEFAULT_COLORS.Default,
        bbox,
        attribution,
        title,
        subtitle,
        description,
        navigationMaps,
        sourceLink,
        cooperativeGestures,
    } = options);
    ```

github-actions · 2024-03-29T10:34:26Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

95.24%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	75.32%	100%	96.88%	124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-02T08:59:41Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

95.24%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	75.32%	100%	96.88%	124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

cybervinvin

After review, I don't have much to say.
There are several things that I find strange but since I don't know the best practices in the SDK, I prefer not to start discussions here.

After using it in the studio, the component API seems OK, so LGTM 👍🏼

KevinFabre-ods · 2024-04-03T13:21:30Z

packages/visualizations/src/components/Table/Pagination/Pages.svelte

+    $: if (totalPages === 2) {
+        pages = [1, 2];
+    } else if (totalPages === 1) {
+        pages = [1];
+    } else if (current - 1 < 1) {
+        pages = [current, current + 1, current + 2];
+    } else if (current + 1 > totalPages) {
+        pages = [current - 2, current - 1, current];
+    } else {
+        pages = [current - 1, current, current + 1];
+    }


It's hard to read, IMO we can improve it:

If totalPages is equal to 3 are less: pages = Array.from({length: totalPages}, (_, i) => i + 1)
if current === 1: pages = [current, current + 1 , current + 2];
if current === totalPages: pages = [current - 2, current - 1, current];
All other cases: pages = [current - 1, current, current + 1];

Ha yes, we can change that computation now that we've changed the indexes to start at 1.

KevinFabre-ods · 2024-04-03T13:24:38Z

packages/visualizations-react/stories/Table/Pagination.stories.tsx

+
+const paginatedOptions = {
+    ...options,
+    pages: {


Suggested change

pages: {

pagination: {

KevinFabre-ods · 2024-04-03T13:40:14Z

packages/visualizations/src/components/Table/Cell/Cell.svelte

@@ -10,7 +11,7 @@
 </script>

 <!-- To display a format value, rawValue must be different from undefined or null -->
-<td class={`table-data--${dataFormat}`}>
+<td class={`table-data--${dataFormat}`} style="max-height: {MAX_ROW_HEIGHT}px">


Indeed the style is in the div but its true height is not maxed at 78px

KevinFabre-ods

Pagination snapshots in Chromatic don't have the pagination element => due to a missing rename (pages => pagination)

Other than that, I think we can improve the readability of the code to computed the page buttons.

Also waiting for your input about the meeting you had with Meg for the pagination behavior.

Finally don't hesitate to reply to my comments when you did or didn't change the code. With a force push commit, comments are detached from the code (sometimes it takes some time to find again the part of the code related to the comment)

github-actions · 2024-04-03T14:35:24Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

95.24%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	75.32%	100%	96.88%	124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-03T15:55:24Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

95.24%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	75.32%	100%	96.88%	124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-04T07:49:35Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

95.24%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	75.32%	100%	96.88%	124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-05T13:36:13Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

95.24%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	75.32%	100%	96.88%	124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-16T14:52:38Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-16T14:52:40Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-18T13:25:53Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-18T13:25:57Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-18T13:37:08Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-18T13:37:14Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-30T09:16:37Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-30T09:16:38Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-30T11:03:37Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-30T11:03:38Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-30T12:04:15Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-30T12:04:18Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-30T12:40:21Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

github-actions · 2024-04-30T12:40:42Z

Coverage after merging feature/sc-46253/sdk-table-pagination into main

94.64%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%
src/client
error.ts	100%	100%	100%
index.ts	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%
src/odsql
clauses.ts	71.43%	80%	90.91%	14, 32, 42
index.ts	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

We'll change that later anyways, but fixes chromatic diff.

etienneburdet force-pushed the feature/sc-46253/sdk-table-pagination branch from 0d91fd1 to 90e6122 Compare March 20, 2024 08:02

etienneburdet requested review from KevinFabre-ods and cybervinvin March 21, 2024 11:53

etienneburdet force-pushed the feature/sc-46253/sdk-table-pagination branch 2 times, most recently from e9b999e to 49dee4c Compare March 22, 2024 08:53

KevinFabre-ods reviewed Mar 26, 2024

View reviewed changes

KevinFabre-ods requested changes Mar 28, 2024

View reviewed changes

packages/visualizations/src/components/Table/Pagination/Pagination.svelte Outdated Show resolved Hide resolved

packages/visualizations/src/components/Table/Pagination/Pagination.svelte Outdated Show resolved Hide resolved

etienneburdet requested a review from KevinFabre-ods March 28, 2024 17:23

etienneburdet force-pushed the feature/sc-46253/sdk-table-pagination branch from 409183d to ab2199f Compare March 29, 2024 10:33

cybervinvin approved these changes Apr 3, 2024

View reviewed changes

KevinFabre-ods reviewed Apr 3, 2024

View reviewed changes

KevinFabre-ods requested changes Apr 3, 2024

View reviewed changes

etienneburdet force-pushed the feature/sc-46253/sdk-table-pagination branch from 2f96758 to d918458 Compare April 3, 2024 14:34

etienneburdet force-pushed the feature/sc-46253/sdk-table-pagination branch from e4eee8e to 7cb5135 Compare April 4, 2024 07:48

etienneburdet added 5 commits April 16, 2024 16:28

feat: add pagination components and stories

edfbb29

feat: add custom styling to pagination

3f482f6

feat: make controls stable in height and stylables

dd3729b

fix: fix typing with new props

d6a1212

chore: update plugin to fix eslint/prettier conflict

91a9666

etienneburdet added 4 commits April 16, 2024 16:29

fix: put back svelte into devDependencies

b7abb5d

fix: simplify pages computation

2d399a4

fix: fix context typing

8cb73cb

rebase main

9d92b0d

etienneburdet force-pushed the feature/sc-46253/sdk-table-pagination branch from a2c0a8f to 9d92b0d Compare April 16, 2024 14:52

etienneburdet requested a review from KevinFabre-ods April 17, 2024 09:42

etienneburdet mentioned this pull request Apr 18, 2024

Chore/simplify-table-styling #230

Closed

chore: merge new styling

d3899da

etienneburdet force-pushed the feature/sc-46253/sdk-table-pagination branch from fc103bc to d3899da Compare April 18, 2024 13:36

fix: make totalpage reactive and fix padding

871ba0a

etienneburdet force-pushed the feature/sc-46253/sdk-table-pagination branch from ae7a29e to 8ca5f6d Compare April 30, 2024 12:03

etienneburdet force-pushed the feature/sc-46253/sdk-table-pagination branch from 8ca5f6d to 26a0713 Compare April 30, 2024 12:39

fix: fix dataformatting

14a3278

We'll change that later anyways, but fixes chromatic diff.

etienneburdet force-pushed the feature/sc-46253/sdk-table-pagination branch from 26a0713 to 14a3278 Compare April 30, 2024 13:10

etienneburdet merged commit 3592c20 into main Apr 30, 2024
7 of 9 checks passed

etienneburdet deleted the feature/sc-46253/sdk-table-pagination branch April 30, 2024 13:19

Feature/sc-46253/sdk-table-pagination #229

Feature/sc-46253/sdk-table-pagination #229

Conversation

etienneburdet commented Mar 20, 2024

Summary

Changes

Changelog

Open discussion

Review checklist

etienneburdet commented Mar 21, 2024

KevinFabre-ods left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KevinFabre-ods left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 28, 2024

etienneburdet commented Mar 28, 2024

github-actions bot commented Mar 29, 2024

etienneburdet commented Mar 29, 2024

github-actions bot commented Mar 29, 2024

github-actions bot commented Apr 2, 2024

cybervinvin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etienneburdet Apr 3, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KevinFabre-ods left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 3, 2024

github-actions bot commented Apr 3, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 5, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 18, 2024

github-actions bot commented Apr 18, 2024

github-actions bot commented Apr 18, 2024

github-actions bot commented Apr 18, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

etienneburdet Apr 3, 2024 •

edited