New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvements on tests of imagecodecs module #25525
Conversation
cd6cce4
to
f925363
Compare
9e41d0b
to
8fa2fb7
Compare
i was not intending to prepare a PR to merge. but now i thing the proposed changes will be useful. please review and consider the file changes baboon.ppm and read.png ( let me create a PR to opencv_extra if this PR acceptable) |
@sturkmen72 What is your motivation of png -> ppm replacement? |
As a final word, the proposed changes are open to discussion. It may be unimportant. Let me do required changes according devs opinions. |
@mshabunin @opencv-alalek what is you opinion? |
@@ -87,11 +87,17 @@ const string all_images[] = | |||
"readwrite/uint16-mono2.dcm", | |||
"readwrite/uint8-rgb.dcm", | |||
#endif | |||
#if defined(HAVE_PNG) || defined(HAVE_SPNG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have GDAL library integration which should support all these image types (PNG, JPEG, TIFF). Perhaps it should be accounted too, though I didn't try to test GDAL backend specifically (with no other backends).
68f2fad
to
f3199a0
Compare
I would choose beautiful Lena over less-than-beautiful baboon. Honestly, I don't see any real justification to make this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[WIP] trivial improvements on tests of imagecodecs module