Improved edge detection sample #25515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
4 tasks
gursimarsingh
added
category: samples
cleanup
vpisarev
reviewed
May 1, 2024
vpisarev
reviewed
May 1, 2024
vpisarev
reviewed
May 1, 2024
18 tasks
asmorkalov
requested changes
May 15, 2024
| string onnxModel = parser.get<string>("model"); | ||
| int backend = parser.get<int>("backend"); | ||
| int target = parser.get<int>("target"); | ||
| int imageSize = parser.get<int>("imageSize"); |
There was a problem hiding this comment.
There is issue with command line parameters handling. Invocation without params leads to sigsegv:
[ WARN:0@0.002] global samples.cpp:61 findFile cv::samples::findFile('baboon.jpg') => '/home/alexander/Projects/OpenCV/opencv-next-build/../opencv-next/samples/data/baboon.jpg'
terminate called after throwing an instance of 'cv::Exception'
what(): OpenCV(5.0.0-pre) /home/alexander/Projects/OpenCV/opencv-next/modules/dnn/src/onnx/onnx_importer.cpp:278: error: (-5:Bad argument) Can't read ONNX file: in function 'ONNXImporter'
Abort (core dumped)
There was a problem hiding this comment.
fixed, canny is now default
| @@ -0,0 +1,31 @@ | |||
| import cv2 as cv | |||
There was a problem hiding this comment.
The new approach destroys original sample with custom layer. Formally, all code blocks are there, but the sample does not create Net and does not use the new layer.
| @@ -1886,7 +1886,7 @@ CV_EXPORTS_W void Laplacian( InputArray src, OutputArray dst, int ddepth, | |||
| //! @addtogroup imgproc_feature | |||
| //! @{ | |||
|
|
|||
| /** @example samples/cpp/edge.cpp | |||
| /** @example samples/dnn/edge_detection.cpp | |||
There was a problem hiding this comment.
We still need simplified API usage example.
Code with 200+ lines are just not suitable for initial leaning steps.
We need 2 kind of "samples":
- simplified API usage example (e.g. move to part of documentation - tutorial_code)
- large "task solution" "demos"
There was a problem hiding this comment.
edge.cpp has been moved to samples/cpp/snippets directory as it has been done for other basic cpp samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25006 #25314
This pull request removes hed_pretrained caffe model to the SOTA dexined onnx model for edge detection. Usage of conventional methods like canny has also been added
The obsolete cpp and python sample has been removed
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.