Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G-API OV backend requires partial shape support #25508

Draft
wants to merge 1 commit into
base: 4.x
Choose a base branch
from

Conversation

DariaMityagina
Copy link
Contributor

@DariaMityagina DariaMityagina commented Apr 29, 2024

Pull Request Readiness Checklist

Addressing the TODO from G-API OV backend requires cv::MediaFrame PR

  • As part of the review process this comment was addressed which make it impossible to run the demo. I will bring those changes back in a separate PR [support PartialShape]

Background_subtraction demo G-API issue:
Porting to API20 resulted in an error (both for CPU and NPU):

[ERROR] OpenCV(4.9.0-dev) /home/runner/work/open_model_zoo/open_model_zoo/cache/opencv/modules/gapi/src/backends/ov/govbackend.cpp:813: error: (-215: assertion not done ) cv::util::holds_alternative<cv::GMatDesc>(input_meta) in function 'cfgPreProcessing'

Adding cv::MediaFrame and partial shape support to govbackend resulted in the following (tested with CPU):
image

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@DariaMityagina DariaMityagina force-pushed the icv/dm/govbackend-partial-shape-support branch from 1d7f137 to 0006726 Compare April 29, 2024 12:36
@asmorkalov asmorkalov added this to the 4.10.0 milestone Apr 29, 2024
@asmorkalov asmorkalov requested review from TolyaTalamanov and dmatveev and removed request for TolyaTalamanov May 1, 2024 07:07
@asmorkalov
Copy link
Contributor

@dmatveev @TolyaTalamanov Friendly reminder.

@asmorkalov asmorkalov modified the milestones: 4.10.0, 4.11.0 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants