Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imshow icons missing when linking the static opencv library #24370

Merged
merged 1 commit into from Oct 12, 2023

Conversation

LiuPeiqiCN
Copy link
Contributor

@LiuPeiqiCN LiuPeiqiCN commented Oct 7, 2023

Fix the issue of missing imshow icons when linking OpenCV as a static library(opencv/opencv-python#585)

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@LiuPeiqiCN LiuPeiqiCN changed the title Fix imshow icons missing when linking the static opencv library(https://github.com/opencv/opencv-python/issues/585) Fix imshow icons missing when linking the static opencv library Oct 11, 2023
@asmorkalov asmorkalov self-requested a review October 12, 2023 17:58
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested manually with QT 5.9.5, Ubuntu 18.04.

@asmorkalov asmorkalov merged commit b3d3acf into opencv:4.x Oct 12, 2023
23 of 24 checks passed
@asmorkalov asmorkalov mentioned this pull request Oct 17, 2023
@asmorkalov asmorkalov added this to the 4.9.0 milestone Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants