New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OpenSSL & various protocol support to FFmpeg backend #229
Changes from 1 commit
a577c57
f2c53bd
77619d3
c746b96
d71b139
bc69c01
991a981
0977132
3dace9e
74d92e0
8fc6035
6f566cd
f621ead
e08dccb
3525469
8aa69b3
af2f0c6
d08a9c9
43704d3
b72fb32
2eb9e03
8e86d77
8d12fd7
4808583
88597ed
399baca
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,7 @@ RUN curl -O -L https://cmake.org/files/v3.9/cmake-3.9.0.tar.gz && \ | |
cd .. && \ | ||
rm -rf cmake-3.9.0* | ||
|
||
RUN yum install autoconf automake bzip2 cmake freetype-devel gcc gcc-c++ libtool make mercurial pkgconfig zlib-devel -y && \ | ||
RUN yum install autoconf automake bzip2 cmake freetype-devel gcc gcc-c++ libtool make mercurial pkgconfig openssl-devel zlib-devel -y && \ | ||
yum remove nasm -y && \ | ||
mkdir ~/ffmpeg_sources && \ | ||
cd ~/ffmpeg_sources && \ | ||
|
@@ -50,7 +50,7 @@ RUN yum install autoconf automake bzip2 cmake freetype-devel gcc gcc-c++ libtool | |
tar xjvf ffmpeg-snapshot.tar.bz2 && \ | ||
cd ffmpeg && \ | ||
PATH=~/bin:$PATH && \ | ||
PKG_CONFIG_PATH="$HOME/ffmpeg_build/lib/pkgconfig" ./configure --prefix="$HOME/ffmpeg_build" --extra-cflags="-I$HOME/ffmpeg_build/include" --extra-ldflags="-L$HOME/ffmpeg_build/lib" --enable-libvpx --enable-shared --enable-pic --bindir="$HOME/bin" && \ | ||
PKG_CONFIG_PATH="$HOME/ffmpeg_build/lib/pkgconfig" ./configure --prefix="$HOME/ffmpeg_build" --extra-cflags="-I$HOME/ffmpeg_build/include" --extra-ldflags="-L$HOME/ffmpeg_build/lib" --enable-libvpx --enable-openssl --enable-protocol=file,ftp,http,https,httpproxy,hls,mmsh,mmst,pipe,rtmp,rtmps,rtmpt,rtmpts,rtp,sctp,srtp,tcp,udp --enable-shared --enable-pic --bindir="$HOME/bin" && \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a particular reason to enable these specific protocols? By default, all supported protocols are enabled AFAICS. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (Not criticizing, just wondering since this looks like just a copied full list at first glance but it's not actually the full list.) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
@native-api Thanks for pointing this out. No there is no specific reason, I just thought these are the most commonly used protocols. Should I remove them? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. I don't think we should change the default without a real reason (I'm not implying that there's none, just that none was presented). |
||
make -j4 && \ | ||
make install && \ | ||
echo "/root/ffmpeg_build/lib/" >> /etc/ld.so.conf && \ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CentOS 5's
openssl
is 0.9.8e which is ancient. Is it safe to use?..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@native-api Wow, I didn't know that will be a problem too. Anyhow, I found this simple tutorial to do that. Should I make these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go the same way other ffmpeg dependencies are built but that guide looks like a good reference point. Can't say much more, it's your job to see that everything hooks up nicely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@native-api Does this library links to an apt-installed FFmpeg in any case or only use this precompiled FFmpeg? I'm not 100% sure that if this patch worked on my machine due to these changes or it used my system FFmpeg during compiling while I'm testing.