Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go-JSON Replacement #1080

Merged
merged 8 commits into from Feb 28, 2022
Merged

Go-JSON Replacement #1080

merged 8 commits into from Feb 28, 2022

Conversation

mbolt35
Copy link
Contributor

@mbolt35 mbolt35 commented Feb 24, 2022

What does this PR change?

How does this PR impact users? (This is the kind of thing that goes in release notes!)

  • Fix for requests which don't receive responses.

How was this PR tested?

  • Using several specific benchmarks that repro'd the bug case in json-iter
  • All kubecost ETL structure json encode/decode unit tests are passing.

@AjayTripathy
Copy link
Contributor

Were we able to test this on the scale cluster for possible performance regressions?

@mbolt35 mbolt35 added needs cherry pick next release This PR/issue is expected to be merged/addressed in the next release labels Feb 28, 2022
@mbolt35 mbolt35 merged commit ca858ec into develop Feb 28, 2022
@michaelmdresser michaelmdresser deleted the bolt/go-json branch March 1, 2022 12:38
@nikovacevic nikovacevic removed next release This PR/issue is expected to be merged/addressed in the next release needs cherry pick labels Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants