Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update dependencies #324

Merged
merged 3 commits into from Jun 19, 2020
Merged

*: update dependencies #324

merged 3 commits into from Jun 19, 2020

Commits on Jun 19, 2020

  1. ci: actually use Go 1.14 

    We need to temporarily hardcode go1.14 as a package name because of issues with
the openSUSE go metapackage[1]. We also need to add a dummy "rootless" user so
that we can avoid issues with Go being confused by where the GOCACHE should
live. There are also some minor improvements to the vendoring tests, and
we have to re-vendor the dependencies because vendor/ has changed under
Go 1.14.

In addition, Go 1.14 now makes "go get" import code into the current
module which causes issues if you actually want to install the bloody
tool (causing "fun" issues like dependencies appearing out of nowhere
and then causing compilation issues becuase the dependency wasn't
vendored). So we have to set GO111MODULE=off in .travis.yml where
applicable.

[1]: https://bugzilla.opensuse.org/show_bug.cgi?id=1172608

Signed-off-by: Aleksa Sarai <asarai@suse.de>

squash! ci: actually use Go 1.14
    @cyphar
    cyphar committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    b802893 View commit details
    Browse the repository at this point in the history

  2. *: update dependencies 

    We haven't done a dependency bump in quite a while, and there are a fair
few fixes and improvements we should get into umoci before the next
release.

  % go get -u
  go: github.com/apex/log upgrade => v1.4.0
  go: github.com/cpuguy83/go-md2man/v2 upgrade => v2.0.0
  go: github.com/golang/protobuf upgrade => v1.4.2
  go: github.com/klauspost/compress upgrade => v1.10.9
  go: github.com/klauspost/cpuid upgrade => v1.3.0
  go: github.com/klauspost/pgzip upgrade => v1.2.4
  go: github.com/konsorten/go-windows-terminal-sequences upgrade => v1.0.3
  go: github.com/opencontainers/go-digest upgrade => v1.0.0
  go: github.com/opencontainers/runtime-spec upgrade => v1.0.2
  go: github.com/pkg/errors upgrade => v0.9.1
  go: github.com/sirupsen/logrus upgrade => v1.6.0
  go: github.com/vbatts/go-mtree upgrade => v0.5.0
  go: golang.org/x/crypto upgrade => v0.0.0-20200604202706-70a84ac30bf9
  go: golang.org/x/net upgrade => v0.0.0-20200602114024-627f9648deb9
  go: golang.org/x/sys upgrade => v0.0.0-20200615200032-f1bc736245b1
  go: google.golang.org/protobuf upgrade => v1.24.0

However there are three issues with this update:

 * We cannot update github.com/urfave/cli to anything later than
   v1.22.1 because of a bug when it comes to StringSliceFlag parsing that we
   hit in CI[1] -- hence the new excludes block.

 * Updating github.com/klauspost/compress to anything later than v1.8.6 causes
   us to generate different gzip-compressed blobs due to an optimisation in
   their compression[2]. Since this is generally a good change to have, we have
   to update our CI so that it works with the newest version (even if it's
   sub-optimal to generate different bytes between versions).

 * Updating github.com/cpuguy83/go-md2man to v2 caused issues with our
   "go get" invocation. It turns out we were silently adding go-md2man
   (v1) to our go.mod file each time we ran a Travis build, and the
   switch to v2 uncovered this issue. This is easily fixed by setting
   GO111MODULE=off when doing 'go get' in .travis.yml.

[1]: urfave/cli#1152
[2]: klauspost/compress#105

Signed-off-by: Aleksa Sarai <asarai@suse.de>
    @cyphar
    cyphar committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    7670d2e View commit details
    Browse the repository at this point in the history

  3. test-unit: run all unit-tests in one shot 

    This might make running the tests a little bit quicker (maybe even more
so if we add t.Parallel() calls in the future), and it removes the need
for collating cover-profile output for each unit test run.

Signed-off-by: Aleksa Sarai <asarai@suse.de>
    @cyphar
    cyphar committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    152acd1 View commit details
    Browse the repository at this point in the history