pwalk, pwalkdir: fix walk vs remove race #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
requested review from
mrunalp,
rhatdan,
runcom and
thaJeztah
as code owners
|
LGTM |
rhatdan
previously approved these changes
Aug 26, 2023
thaJeztah
previously approved these changes
Aug 26, 2023
There was a problem hiding this comment.
overall LGTM (nice!), but found 2 redundant defers, and left a suggestion.
don't think they're necessarily show-stoppers, but I'll let @kolyshkin have a look before merging 👍
Use t.Helper and t.Cleanup in prepareTestSet to simplify tests setup and cleanup (no need to call defer os.Remove or check error). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
In some cases, when file walk is racing with removal, the ENOENT is received by filepath.Walk[Dir], rather than by the callback. Do ignore such errors, except for the root directory (Walk argument). Modify the doc accordingly, and add a couple of test cases. The "Race" test case, when testing the code before the fix, fails 100% of times for pwalk and 90% for pwalkdir. Alas, I was unable to make it fail 100% of the times without significantly increasing the test complexity. Fixes: 199 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, when file walk is racing with removal, the ENOENT is
received by filepath.Walk[Dir], rather than by the callback.
Do ignore such errors, except for the root directory (Walk argument).
Modify the doc accordingly, and add a couple of test cases.
The "Race" test case, when testing the code before the fix, fails 100%
of times for pwalk and 90% for pwalkdir. Alas, I was unable to make it
fail 100% of the times without significantly increasing the test
complexity.
Fixes: #199