Add Go 1.20 support; require Go 1.19; drop Go 1.17 and 1.18 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
requested review from
kolyshkin,
mrunalp,
rhatdan,
runcom and
thaJeztah
as code owners
kolyshkin
reviewed
Feb 3, 2023
There was a problem hiding this comment.
I think that those jobs that explicitly use go 1.19 should switch to 1.20 as well.
Also, maybe we can drop go 1.17 support, as this is not supported by upstream since go 1.19 is released half a year ago; @rhatdan what do you think?
|
I agree we should move to 1.19 and 1.20 |
austinvazquez
force-pushed
the
add-go-1.20
branch
from
726a716
to
23a10a9
Compare
austinvazquez
changed the title
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
add-go-1.20
branch
from
23a10a9
to
f257026
Compare
|
I had missed bumping the version for test-stubs/golangci-lint. Should be addressed now. |
|
LGTM |
|
Oh it looks like I have confused the GitHub UI. Right now it is showing the Go 1.17 and 1.18 checks as pending, but we have removed those from the testing matrix. So really the checks are green right now. |
|
@kolyshkin @thaJeztah PTAL |
|
(I've changed the list of CI jobs required for merge -- removed older versions, added 1.20.x) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Austin Vazquez macedonv@amazon.com