gha: update golangci-lint to v1.46, add Go 1.18, remove Go 1.15 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
changelog; https://github.com/actions/checkout/blob/v3.0.2/CHANGELOG.md Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- to get new build-tag format - to account for go1.19 changes in formatting godoc Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
v3 requires Go to be set up manually (whereas previous versions would install their own version, which may not match the expected version). Also removing the "new code only" constraint; let's just check all code for issues. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Closed
|
We'll need to update the list of required checks after this is merged (otherwise CI will continue waiting for them). Test-run in thaJeztah#1 |
thaJeztah
requested review from
kolyshkin,
mrunalp,
rhatdan and
runcom
as code owners
Ah, ok, looks like it's already needed "before" merging |
|
@kolyshkin @rhatdan PTAL |
|
LGTM |
|
Thanks! I updated the repo configuration for the new checks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details