Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] allow overriding VERSION value in Makefile #4270

Merged
merged 1 commit into from
May 7, 2024

Conversation

akhilerm
Copy link
Contributor

@akhilerm akhilerm commented May 6, 2024

This is a backport of #4269.


this allows using a custom version string while building runc without modifying the VERSION file

(cherry picked from commit 9d9273c)

this allows using a custom version string while building runc
without modifying the VERSION file

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
(cherry picked from commit 9d9273c)
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@akhilerm
Copy link
Contributor Author

akhilerm commented May 7, 2024

The failure in vagrant -- fedora seems unrelated. Can someone retrigger the failed test?

@kolyshkin kolyshkin added this to the 1.1.13 milestone May 7, 2024
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin added the backport/1.1-pr A backport to 1.1.x release. label May 7, 2024
@AkihiroSuda AkihiroSuda merged commit 007abf3 into opencontainers:release-1.1 May 7, 2024
29 checks passed
@akhilerm akhilerm deleted the backport-1.1-4269 branch May 20, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.1-pr A backport to 1.1.x release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants