Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] libcontainer: force apps to think fips is enabled/disabled for testing #4257

Merged
merged 1 commit into from Apr 26, 2024

Conversation

sohankunkerkar
Copy link
Contributor

@sohankunkerkar sohankunkerkar commented Apr 25, 2024

This is a backport of #4246 to release-1.1. Original description follows.

The motivation behind this change is to provide a flexible mechanism for containers within a Kubernetes cluster to opt out of FIPS mode when necessary. This change enables apps to simulate FIPS mode being enabled or disabled for testing. Users can control whether apps believe FIPS mode is on or off by manipulating /proc/sys/crypto/fips_enabled.

@sohankunkerkar sohankunkerkar force-pushed the release-1.1 branch 3 times, most recently from 41886f9 to 58e308b Compare April 25, 2024 18:21
@sohankunkerkar sohankunkerkar changed the title [1.1 backport] libcontainer: force apps to think fips is enabled/disabled for testing [1.1] libcontainer: force apps to think fips is enabled/disabled for testing Apr 25, 2024
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kolyshkin kolyshkin added the backport/1.1-pr A backport to 1.1.x release. label Apr 25, 2024
@kolyshkin kolyshkin added this to the 1.1.13 milestone Apr 25, 2024
The motivation behind this change is to provide a flexible mechanism for
containers within a Kubernetes cluster to opt out of FIPS mode when necessary.
This change enables apps to simulate FIPS mode being enabled or disabled for testing
purposes. Users can control whether apps believe FIPS mode is on or off by manipulating
`/proc/sys/crypto/fips_enabled`.

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@mrunalp mrunalp merged commit e8bb71e into opencontainers:release-1.1 Apr 26, 2024
29 checks passed
@sohankunkerkar sohankunkerkar deleted the release-1.1 branch April 26, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.1-pr A backport to 1.1.x release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants