libct/cg: write unified resources line by line #4186
+89
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smileusd does this fix your issue? |
It has been pointed out that some controllers can not accept multiple lines of output at once. In particular, io.max can only set one device at a time. Practically, the only multi-line resource values we can get come from unified.* -- let's write those line by line. Add a test case. Reported-by: Tao Shen <shentaoskyking@gmail.com> Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
multi-line
branch
from
2633837
to
d45970c
Compare
|
-> @smileusd does this fix your issue? |
lifubang
reviewed
May 14, 2024
| // is is written line by line. | ||
| func WriteFileByLine(dir, file, data string) error { | ||
| i := strings.Index(data, "\n") | ||
| if i == -1 { |
There was a problem hiding this comment.
I think we can remove this special block.
Others LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been pointed out (in #4182) that some controllers can not accept multiple lines of output at once. In particular, io.max can only set one device at a time.
Practically, the only multi-line resource values we can get come from unified.* -- let's write those line by line.
Add a test case.
Reported-by: Tao Shen shentaoskyking@gmail.com
Closes: #4182