tests/int: fix flaky kill tests #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
force-pushed
the
ci-fix-kill-flake
branch
7 times, most recently
from
142bcb7
to
c5f3ad5
Compare
kolyshkin
force-pushed
the
ci-fix-kill-flake
branch
from
c5f3ad5
to
267056c
Compare
kolyshkin
force-pushed
the
ci-fix-kill-flake
branch
2 times, most recently
from
696fc90
to
a060e35
Compare
It takes some time for the kernel to kill the process (and remove its PID from cgroup.procs). To ensure we don't have flakes from reading cgroup.procs right after the kill, check and wait for processes to actually be gone. Fixes: 4163 Reported-by: lifubang@acmcoder.com Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
ci-fix-kill-flake
branch
from
a060e35
to
8636059
Compare
AkihiroSuda
approved these changes
Mar 1, 2024
cyphar
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It takes some time for the kernel to kill the process (and remove its
PID from cgroup.procs). To ensure we don't have flakes from reading
cgroup.procs right after the kill, check and wait for processes to
actually be gone.
Fixes: #4163