Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcontainer: include cgroupv2 memory.events in Manager.GetStats #4120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

libcontainer: include cgroupv2 memory.events in Manager.GetStats #4120

wants to merge 1 commit into from

Conversation

Zheaoli
Copy link
Contributor

@Zheaoli Zheaoli commented Nov 14, 2023

Carry #3608

Signed-off-by: Zheao.Li me@manjusaka.me

@Zheaoli
Copy link
Contributor Author

Zheaoli commented Nov 15, 2023

@AkihiroSuda Would you mind to retry the test for me? some of them failed because of the APT apt throttled

@Zheaoli
Copy link
Contributor Author

Zheaoli commented Nov 15, 2023 

E: Failed to fetch https://download.opensuse.org/repositories/devel:/tools:/criu/xUbuntu_22.04/amd64/criu_3.18-1_amd64.deb  Redirection from https to 'http://provo-mirror.opensuse.org/repositories/devel%3A/tools%3A/criu/xUbuntu_22.04/amd64/criu_3.18-1_amd64.deb' is forbidden [IP: 195.135.223.226 443]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

Seems we will find the same error on other action

@Zheaoli Zheaoli force-pushed the manjusaka/carry-3608 branch 4 times, most recently from ef6ffba to ea0e2df Compare November 30, 2023 13:42
@Zheaoli
Copy link
Contributor Author

Zheaoli commented Nov 30, 2023

@AkihiroSuda ping for review（

AkihiroSuda
AkihiroSuda reviewed Dec 1, 2023
View reviewed changes
types/events.go Outdated Show resolved Hide resolved
@Zheaoli Zheaoli force-pushed the manjusaka/carry-3608 branch 2 times, most recently from 4d75890 to bffe907 Compare December 12, 2023 18:49
lifubang
lifubang reviewed Dec 20, 2023
View reviewed changes
libcontainer/cgroups/stats.go Outdated
PSI *PSIStats `json:"psi,omitempty"`
Stats map[string]uint64 `json:"stats,omitempty"`
PSI *PSIStats `json:"psi,omitempty"`
EventCount MemoryEventsCount `json:"events_count,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A follow-up name matching situation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/events_count/event_count/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zheaoli Why you ignored this one?

lifubang
lifubang reviewed Dec 20, 2023
View reviewed changes
types/events.go Outdated Show resolved Hide resolved
@Zheaoli Zheaoli force-pushed the manjusaka/carry-3608 branch 3 times, most recently from f64b64e to 0d8b4d9 Compare January 16, 2024 06:54
@Zheaoli
libcontainer: include cgroupv2 memory.events in Manager.GetStats
12aaa2b 
Signed-off-by: Zheao.Li <me@manjusaka.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda Awaiting requested review from AkihiroSuda

@lifubang lifubang Awaiting requested review from lifubang

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zheaoli @lifubang @kolyshkin @AkihiroSuda