Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.3 #3490

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Release 1.1.3 #3490

merged 3 commits into from
Jun 9, 2022

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented May 26, 2022

Let's cook 1.1.3. Copy-paste from the CHANGELOG.md below.


[1.1.3] - 2022-06-08

In the beginning there was nothing, which exploded.

Fixed

Added

Changed

@kolyshkin kolyshkin added this to the 1.1.3 milestone May 26, 2022
@kolyshkin kolyshkin requested a review from cyphar May 26, 2022 20:52
@cyphar
Copy link
Member

cyphar commented May 26, 2022

I'd like to backport #3451 first. Also when do we want to do a runc 1.2 release?

@kolyshkin
Copy link
Contributor Author

Also when do we want to do a runc 1.2 release?

I say let's try to do it in June. There are some PRs in the milestone.

@kolyshkin
Copy link
Contributor Author

I'd like to backport #3451 first.

Changelog entry added.

@kolyshkin kolyshkin force-pushed the 1.1.3 branch 2 times, most recently from dc36d0e to 9eb865a Compare June 2, 2022 17:54
@kolyshkin
Copy link
Contributor Author

@cyphar @AkihiroSuda @thaJeztah PTAL

thaJeztah
thaJeztah previously approved these changes Jun 2, 2022
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for preparing!

@AkihiroSuda AkihiroSuda closed this Jun 4, 2022
@AkihiroSuda AkihiroSuda reopened this Jun 4, 2022
@AkihiroSuda
Copy link
Member

Is this still WIP/DNM?

@kolyshkin
Copy link
Contributor Author

Is this still WIP/DNM?

Can't be committed until we know the release date (and that depends on @cyphar). Otherwise not a WIP.

@kolyshkin kolyshkin force-pushed the 1.1.3 branch 2 times, most recently from 5530320 to 5b73eab Compare June 7, 2022 23:46
@cyphar cyphar marked this pull request as ready for review June 7, 2022 23:49
@kolyshkin kolyshkin changed the title [WIP/DNM] Release 1.1.3 Release 1.1.3 Jun 7, 2022
@cyphar cyphar marked this pull request as draft June 7, 2022 23:51
@cyphar
Copy link
Member

cyphar commented Jun 7, 2022

Just waiting for #3504 (which needs #3498) to be merged and then this is ready IMHO.

@thaJeztah
Copy link
Member

Both were merged 👍

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Perform some basic checks for CHANGELOG.md.

In particular, check for
 - missing periods;
 - extra spaces at EOL;
 - non-ASCII characters.

Fix the issues found.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
* Changelog for v1.1.3.
* Fixed 1.1.2 release date.
* Fixed the order of footnotes.

Note that backport (rather than original) PRs are listed as references,
since this makes it easier to cross-check against the git log.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin marked this pull request as ready for review June 8, 2022 18:47
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cyphar cyphar merged commit 1e7bb5b into opencontainers:release-1.1 Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants