Reformat "Platform Variants", especially to add amd64, ppc64le, riscv64 #1172
Conversation
tianon
requested review from
jonjohnsonjr,
jonboulle,
stevvooe,
sudo-bmitch,
sajayantony,
vbatts and
cyphar
as code owners
This changes the table to be a line per ISA instead of per variant; adds x86-64, POWER8+, and RISC-V; and notes the appropriate "Go analog" in each case (because these values mirror Go's choices, like our use of `GOOS` and `GOARCH`). Of particular note, `GOARM64` and `GORISCV64` are not fully implemented or released in Go yet, but they are accepted proposals with in-progress implementations or already merged to main: - `GOARM64`: https://golang.org/issue/60905 - `GORISCV64`: https://golang.org/issue/61476#issuecomment-1791156741 Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
tianon
force-pushed
the
platform-variants
branch
from
dd2fe12
to
2d95dde
Compare
| | ARM 32-bit, v7 | `arm` | `v7` | | ||
| | ARM 32-bit, v8 | `arm` | `v8` | | ||
| | ARM 64-bit, v8 | `arm64` | `v8` | | ||
| These values SHOULD match (or be similar to) their analog listed in [the Go Language document][go-environment2]. |
There was a problem hiding this comment.
(or be similar to)
This part makes me nuts, but I felt like I had to somehow address that GOARM does not use a v prefix, GOARM64 will not (at least initially) support v8 (without a minor, like v8.0), we don't do extra things like softfloat or sse2 in this field, etc SOMEHOW in this wording.
There was a problem hiding this comment.
Hm, i would be more explicit in tags that are supported. One can reference go constants as valid ones, but specify them explicitly.
There will always be variants that are not yet specified or relevant for go, but do make sense to be explicit for container images that contain code that was written in other languages. For example, whilst GOARM64 is already defined, it doesn't actually do anything different in go - but it does for gcc for example.
There was a problem hiding this comment.
The table below does include explicit examples, though 😅
This changes the table to be a line per ISA instead of per variant; adds x86-64, POWER8+, and RISC-V; and notes the appropriate "Go analog" in each case (because these values mirror Go's choices, like our use of
GOOSandGOARCH).Of particular note,
GOARM64andGORISCV64are not fully implemented or released in Go yet, but they are accepted proposals with in-progress implementations or already merged to main:GOARM64: all: add GOARM64=v8.1 and so on golang/go#60905GORISCV64: all: add GORISCV64 environment variable golang/go#61476 (comment)Closes #852