Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-types: Fix broken links #1163

Merged
merged 1 commit into from Feb 17, 2024
Merged

media-types: Fix broken links #1163

merged 1 commit into from Feb 17, 2024

Conversation

coolljt0725
Copy link
Member

Related to distribution/distribution#4101, This PR move spec/manifest-v2-2.md to content/spec/manifest-v2-2.md

sudo-bmitch
sudo-bmitch requested changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@sudo-bmitch sudo-bmitch left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference is to depend on a tag rather than the master branch. Once the 3.0 release goes GA there, we can adjust the tags and paths together. It also looks like the image manifest anchor has been wrong so this is a good opportunity to fix that too.

media-types.md Outdated Show resolved Hide resolved
media-types.md Outdated Show resolved Hide resolved
@coolljt0725
media-types: Fix broken links
8baa69b 
Related to distribution/distribution#4101

Signed-off-by: Lei Jitang <leijitang@outlook.com>
@coolljt0725
Copy link
Member Author

updated according to @sudo-bmitch 's suggestions.

thaJeztah
thaJeztah approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sudo-bmitch
sudo-bmitch approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd recommend holding off on the final merge until after the 1.1.0 vote completes.

@tianon tianon merged commit 08a9ca2 into opencontainers:main Feb 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@sudo-bmitch sudo-bmitch sudo-bmitch approved these changes

@jonjohnsonjr jonjohnsonjr Awaiting requested review from jonjohnsonjr jonjohnsonjr is a code owner

@jonboulle jonboulle Awaiting requested review from jonboulle jonboulle is a code owner

@stevvooe stevvooe Awaiting requested review from stevvooe stevvooe is a code owner

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@vbatts vbatts Awaiting requested review from vbatts

@cyphar cyphar Awaiting requested review from cyphar cyphar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@coolljt0725 @tianon @thaJeztah @sudo-bmitch