Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor typo in doc comment of specs-go #1054

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fix minor typo in doc comment of specs-go #1054

merged 1 commit into from
Apr 27, 2023

Conversation

imjasonh
Copy link
Member

ppc64 is not a valid architecture, but ppc64le is.

@imjasonh
Update descriptor.go
2720969 
Signed-off-by: Jason Hall <jason@chainguard.dev>
tianon
tianon approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree 100% with this change, but do want to clarify that ppc64 is valid for big endian 64bit POWER and this isn't necessarily a typo or incorrect, but ppc64le is much more common and thus a better example 😅

(https://go.dev/doc/install/source#environment)

@sudo-bmitch sudo-bmitch merged commit 23d55d3 into opencontainers:main Apr 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon approved these changes

@sudo-bmitch sudo-bmitch sudo-bmitch approved these changes

@jonjohnsonjr jonjohnsonjr Awaiting requested review from jonjohnsonjr jonjohnsonjr is a code owner

@jonboulle jonboulle Awaiting requested review from jonboulle

@stevvooe stevvooe Awaiting requested review from stevvooe stevvooe is a code owner

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@vbatts vbatts Awaiting requested review from vbatts

@cyphar cyphar Awaiting requested review from cyphar cyphar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imjasonh @tianon @sudo-bmitch