Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RT-1.33 changes #2998

Merged
merged 4 commits into from
May 22, 2024
Merged

RT-1.33 changes #2998

merged 4 commits into from
May 22, 2024

Conversation

arvbaska1
Copy link
Contributor

Made below changes to the test

  • Change AS# for Port2 DUT-ATE BGP sessions for routes to be advertised to that eBGP Peer , same AS wont work due to AS PATH loop prevention.
  • Added soft reconfiguration inbound CLI with MissingPrePolicyReceivedRoutes deviation for pre-policy routes
  • Increase timeouts in watch in validatePrefixCount to account for default sample interval with gnmi target-defined sub

@arvbaska1 arvbaska1 requested review from a team as code owners May 17, 2024 20:50
@OpenConfigBot
Copy link

OpenConfigBot commented May 17, 2024 •
edited

Pull Request Functional Test Report for #2998 / 83bb1a9

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
 RT-1.33: BGP Policy with prefix-set matching
Cisco 8000E status
 RT-1.33: BGP Policy with prefix-set matching
Cisco XRd status
 RT-1.33: BGP Policy with prefix-set matching
Juniper ncPTX status
 RT-1.33: BGP Policy with prefix-set matching
Nokia SR Linux status
 RT-1.33: BGP Policy with prefix-set matching
Openconfig Lemming status
 RT-1.33: BGP Policy with prefix-set matching

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
 RT-1.33: BGP Policy with prefix-set matching
Cisco 8808 status
 RT-1.33: BGP Policy with prefix-set matching
Juniper PTX10008 status
 RT-1.33: BGP Policy with prefix-set matching
Nokia 7250 IXR-10e status
 RT-1.33: BGP Policy with prefix-set matching

Help

@coveralls
Copy link

coveralls commented May 17, 2024 •
edited

Pull Request Test Coverage Report for Build 9134333334

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.859%
Totals Coverage Status
Change from base Build 9132154745: 0.0%
Covered Lines: 1983
Relevant Lines: 3550
💛 - Coveralls

@hnnagashree hnnagashree requested a review from AmrNJ May 21, 2024 14:57
AmrNJ
AmrNJ approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@AmrNJ AmrNJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AmrNJ AmrNJ merged commit 6942420 into openconfig:main May 22, 2024
13 checks passed
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request May 23, 2024
@arvbaska1 @frasieroh
RT-1.33 changes (openconfig#2998)
b4fbbe0 
* RT-1.33 changes

* address readme ci check fail

* fix typo

* fix readme check
@cprabha cprabha mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@self-maurya self-maurya self-maurya approved these changes

@AmrNJ AmrNJ AmrNJ approved these changes

@jasdeep-hundal jasdeep-hundal Awaiting requested review from jasdeep-hundal jasdeep-hundal is a code owner automatically assigned from openconfig/featureprofiles-maintainers-otg

Assignees
No one assigned
Labels
cisco-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arvbaska1 @OpenConfigBot @coveralls @self-maurya @AmrNJ