-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FNT] Forwarding viability Test aggregate_all_not_viable_test #2953
base: main
Are you sure you want to change the base?
Conversation
Pull Request Functional Test Report for #2953 / 3a81f58Virtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 9349681911Details
💛 - Coveralls |
9895a65
to
f5fab17
Compare
feature/interface/aggregate/otg_tests/aggregate_all_not_viable_test/README.md
Outdated
Show resolved
Hide resolved
feature/interface/aggregate/otg_tests/aggregate_all_not_viable_test/README.md
Outdated
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Outdated
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Outdated
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Show resolved
Hide resolved
feabd53
to
f12b41e
Compare
feature/interface/aggregate/otg_tests/aggregate_all_not_viable_test/README.md
Outdated
Show resolved
Hide resolved
d160fec
to
d9a2574
Compare
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Outdated
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Outdated
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Outdated
Show resolved
Hide resolved
feature/interface/aggregate/otg_tests/aggregate_all_not_viable_test/BUILD
Outdated
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Show resolved
Hide resolved
91796ca
to
d9a2574
Compare
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Outdated
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Outdated
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Show resolved
Hide resolved
...ggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go
Outdated
Show resolved
Hide resolved
- Establish ISIS adjacencies on LAG_1, LAG_2, LAG_3. | ||
1. Advertise one network prefix (pfx1) from ATE LAG_1 | ||
1. Advertise one network prefix (pfx2) from ATE LAG_2 and ATE LAG_3. | ||
- Establish iBGP between ATE and DUT over LGA_1 using LAG_1 interface IPs and advertise prefix pfx3 with BGP NH from pfx2 range. | ||
- Establish iBGP between ATE and DUT over LGA using LAG interface IPs and | ||
advertise prefix pfx3 with BGP NH from pfx2 range. | ||
- Programm via gRIBI route for prefix pfx4 with single NHG pointing LAG_2 (al |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dplore , i think the idea of forwarding-viable is switch to backup NHG if available when all member of primary are set forwarding-viable=False . I don't think we have that coverage. Can we add backup NHG pointing to LAG3 and verify that gRIBI traffic switched to LAG3 when all member of LAG2 are set to False and similarly it is switched back to primary ( LAG2) when any of the member set to forwarding-viable True . ( PS: we can ignore this case here if it planned as part of gRIBI test cases)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here instead of NHG we are switching all the traffic to LAG3 if all ports of LAG2 are set forwarding-viable=False.
Please let me know if anything need to be added so that i will change it accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rahulsy26 , Iam talking about gRIBI route traffic . that is getting dropped when all members of LAG2 are down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets wait for @dplore to comment on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should include a backup-NHG. We will have the scenario where Backup-NHG is present and a LAG will have all member interfaces set to forwarding-viable=FALSE. The backup-NHG should take effect in this scenario. @nflath for any other comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want at least one test for the backup-NHG programming, correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted
3a81f58
to
3e595d3
Compare
3d182ef
to
acf7c79
Compare
This reverts commit 45c5e722786ceee387fb74f763ea5a685b07dc80.
This reverts commit d8bc4adba96589aa6e6f109a5ea2679f4621ae8a.
e5063f6
to
5fdd136
Compare
5fdd136
to
0b60263
Compare
Summary:
This code is to Test forwarding-viable with LAG and routing
Ensure that when all LAG member become set with forwarding-viable == FALSE.
forwarding-viable=false impact only transmit traffic on all member port.
All member ports set with forwarding-viable=false can receive all type of traffic and forward it normally (same as with forwarding-viable=true)
ISIS adjacency is established on LAG port w/ all member set to forwarding-viable == FALSE
Traffic that normally egress LAG with all members set to forwarding-viable == FALSE is forwarded by the next best egress interface/LAG.