Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FNT] Forwarding viability Test aggregate_all_not_viable_test #2953

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rahulsy26
Copy link

@rahulsy26 rahulsy26 commented May 3, 2024

Summary:
This code is to Test forwarding-viable with LAG and routing

Ensure that when all LAG member become set with forwarding-viable == FALSE.

forwarding-viable=false impact only transmit traffic on all member port.
All member ports set with forwarding-viable=false can receive all type of traffic and forward it normally (same as with forwarding-viable=true)
ISIS adjacency is established on LAG port w/ all member set to forwarding-viable == FALSE
Traffic that normally egress LAG with all members set to forwarding-viable == FALSE is forwarded by the next best egress interface/LAG.

@rahulsy26 rahulsy26 requested review from a team as code owners May 3, 2024 04:02
@rahulsy26 rahulsy26 requested a review from michaelore May 3, 2024 04:02
@OpenConfigBot
Copy link

OpenConfigBot commented May 3, 2024

Pull Request Functional Test Report for #2953 / 3a81f58

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-5.7: Aggregate Not Viable All
7bc46c61 Log
Cisco 8000E status
RT-5.7: Aggregate Not Viable All
6d288713 Log
Cisco XRd status
RT-5.7: Aggregate Not Viable All
d4df983b Log
Juniper ncPTX status
RT-5.7: Aggregate Not Viable All
bad6c573 Log
Nokia SR Linux status
RT-5.7: Aggregate Not Viable All
cf9c2c6f Log
Openconfig Lemming status
RT-5.7: Aggregate Not Viable All
05c4d269 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-5.7: Aggregate Not Viable All
Cisco 8808 status
RT-5.7: Aggregate Not Viable All
Juniper PTX10008 status
RT-5.7: Aggregate Not Viable All
Nokia 7250 IXR-10e status
RT-5.7: Aggregate Not Viable All

Help

@coveralls
Copy link

coveralls commented May 3, 2024

Pull Request Test Coverage Report for Build 9349681911

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%

Totals Coverage Status
Change from base Build 9346450617: 0.0%
Covered Lines: 1983
Relevant Lines: 3573

💛 - Coveralls

@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch 7 times, most recently from 9895a65 to f5fab17 Compare May 3, 2024 13:24
@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch 6 times, most recently from feabd53 to f12b41e Compare May 6, 2024 15:47
@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch from d160fec to d9a2574 Compare May 9, 2024 13:19
nflath
nflath previously approved these changes May 28, 2024
- Establish ISIS adjacencies on LAG_1, LAG_2, LAG_3.
1. Advertise one network prefix (pfx1) from ATE LAG_1
1. Advertise one network prefix (pfx2) from ATE LAG_2 and ATE LAG_3.
- Establish iBGP between ATE and DUT over LGA_1 using LAG_1 interface IPs and advertise prefix pfx3 with BGP NH from pfx2 range.
- Establish iBGP between ATE and DUT over LGA using LAG interface IPs and
advertise prefix pfx3 with BGP NH from pfx2 range.
- Programm via gRIBI route for prefix pfx4 with single NHG pointing LAG_2 (al
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dplore , i think the idea of forwarding-viable is switch to backup NHG if available when all member of primary are set forwarding-viable=False . I don't think we have that coverage. Can we add backup NHG pointing to LAG3 and verify that gRIBI traffic switched to LAG3 when all member of LAG2 are set to False and similarly it is switched back to primary ( LAG2) when any of the member set to forwarding-viable True . ( PS: we can ignore this case here if it planned as part of gRIBI test cases)

Copy link
Author

@rahulsy26 rahulsy26 May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here instead of NHG we are switching all the traffic to LAG3 if all ports of LAG2 are set forwarding-viable=False.

Please let me know if anything need to be added so that i will change it accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahulsy26 , Iam talking about gRIBI route traffic . that is getting dropped when all members of LAG2 are down.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait for @dplore to comment on this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should include a backup-NHG. We will have the scenario where Backup-NHG is present and a LAG will have all member interfaces set to forwarding-viable=FALSE. The backup-NHG should take effect in this scenario. @nflath for any other comment

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want at least one test for the backup-NHG programming, correct.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted

@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch from 3a81f58 to 3e595d3 Compare May 29, 2024 12:37
@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch 2 times, most recently from 3d182ef to acf7c79 Compare June 3, 2024 08:48
This reverts commit 45c5e722786ceee387fb74f763ea5a685b07dc80.
This reverts commit d8bc4adba96589aa6e6f109a5ea2679f4621ae8a.
@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch 4 times, most recently from e5063f6 to 5fdd136 Compare June 3, 2024 11:23
@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch from 5fdd136 to 0b60263 Compare June 3, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants