Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put cdn.putDir logic inside OC #1321

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Put cdn.putDir logic inside OC #1321

wants to merge 2 commits into from

Conversation

ricardo-devis-agullo
Copy link
Collaborator

This puts the putDir logic back on OC. The reason is that

  1. The logic is the same for all storage adapters (since no storage has really the concept of directories, it just does a loop of putFiles)
  2. There's specific OC logic (making server.js and .env private) that doesn't belong on storage adapters, because they should be agnostic about OC and just have the simple logic of managing files on a storage.

@ricardo-devis-agullo ricardo-devis-agullo mentioned this pull request Jan 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ricardo-devis-agullo