Skip to content

Update project to Node.js 14.x #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

olof-nord
Copy link
Contributor

Please provide enough information so that others can review your pull request:

This PR increases the minimum supported Node.js version to 14.x.

Explain the details for making this change. What existing problem does the pull request solve?

Version 12 of Node.js is no longer supported, 14 is in maintenance with a scheduled end of life 2023-04-30.

https://github.com/nodejs/Release

Test plan (required)

$ node --version
v14.20.1
npm run test

...

  754 passing (12s)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Closing issues

closes #1307

Version 12 is no longer supported, 14 is in maintenance with a scheduled end of life 2023-04-30.
@olof-nord
Copy link
Contributor Author

Ping @ricardo-devis-agullo, as you were the one involved in my previous, similar PR.
I see this change as quite trivial, with not much risk. Going forward, perhaps one may also take Node.js v18 into account - ill put something together for this later too.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ricardo-devis-agullo ricardo-devis-agullo merged commit 22cf77e into opencomponents:master Oct 11, 2022
@olof-nord olof-nord deleted the node-v14 branch October 12, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update project to Node.js 14.x
2 participants