[CB-INTERNAL] move components-details and repository to promises #1265
+316
−390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardo-devis-agullo
changed the title
pbazydlo
reviewed
Oct 28, 2021
| const dirDetails = await getFromDirectories({ | ||
| componentsList, | ||
| details: jsonDetails | ||
| }).catch(err => returnError('components_details_get', err)); |
There was a problem hiding this comment.
returnError will throw and thus refresh will finish on this line in case of error, right?
There was a problem hiding this comment.
correct, if you throw inside catch its like rethrowing
pbazydlo
reviewed
Oct 28, 2021
| if (componentName === 'oc-client') { | ||
| return callback(null, [ | ||
| fs.readJsonSync(path.join(__dirname, '../../../package.json')).version | ||
| return Promise.all([ |
There was a problem hiding this comment.
why Promise.all and not Promise.resolve?
There was a problem hiding this comment.
Because it's an array of promises, not a promise of an array.
pbazydlo
reviewed
Oct 28, 2021
| callback(null, [ | ||
| fs.readJsonSync(path.join(conf.path, `${componentName}/package.json`)) | ||
| .version | ||
| return Promise.all([ |
There was a problem hiding this comment.
Because it's an array of promises, not a promise of an array.
pbazydlo
reviewed
Oct 28, 2021
pbazydlo
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully move components-details and repository to Promises