Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Proposal to use react-pdf (based on PDFKit) #7177

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

Betree
Copy link
Member

@Betree Betree commented Jan 2, 2024

No description provided.

@Betree Betree self-assigned this Jan 2, 2024
@Betree Betree changed the title RFC: New proposal to use PDFKit RFC: Proposal to use PDFKit Jan 2, 2024
@Betree
Copy link
Member Author

Betree commented Jan 8, 2024

@Betree Betree marked this pull request as draft January 8, 2024 12:35
@Betree Betree changed the title RFC: Proposal to use PDFKit RFC: Proposal to use react-pdf (based on PDFKit) Feb 20, 2024
## Drawbacks

- Inability to reuse frontend React components as PDFKit does not rely on Web/CSS technologies.
- Lack of proper support for tables. **This is currently a blocker for this RFC**. The status is:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we use tables for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transactions list

@gustavlrsn
Copy link
Member

I think the library looks good. For styling there's a plugin to enable using tailwind: https://github.com/aanckar/react-pdf-tailwind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants