Fix sumCollectiveTransactions #9764
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @gustavlrsn and the rest of your teammates on |
gustavlrsn
force-pushed
the
01-31-Fix_sumCollectiveTransactions
branch
from
c8a1e1e
to
e0a56eb
Compare
gustavlrsn
force-pushed
the
01-31-Fix_sumCollectiveTransactions
branch
from
e0a56eb
to
001e98e
Compare
znarf
reviewed
Feb 6, 2024
Comment on lines
+623
to
+625
| ...(transactionType === 'CREDIT_WITH_HOST_FEE_AND_PAYMENT_PROCESSOR_FEE' && { | ||
| OrderId: { [Op.not]: null }, | ||
| }), |
There was a problem hiding this comment.
Could you add a detailed comment to explain what's going on here?
znarf
reviewed
Feb 6, 2024
| [Op.or]: [ | ||
| { type: CREDIT }, | ||
| { type: DEBIT, kind: 'HOST_FEE' }, | ||
| { type: DEBIT, kind: 'PAYMENT_PROCESSOR_FEE', OrderId: { [Op.not]: null } }, |
There was a problem hiding this comment.
Now that I'm looking at it again, would be great to add a comment to explain why we're doing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure to only include payment processor fee transactions for contributions when calculating net amount received.