Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript: Move more sequelize model attributes to declare #7558

Merged
merged 2 commits into from Aug 24, 2022

Conversation

Betree
Copy link
Member

@Betree Betree commented May 19, 2022

Resolve opencollective/opencollective#5099
Resolve opencollective/opencollective#5575

Also fixes a potential bug that did not occur because the frontend always submits an amount, but omitting it in editExpense would have crashed the mutation.

@Betree Betree self-assigned this May 19, 2022
@Betree Betree force-pushed the debt/sequelize-ts-attributes branch 6 times, most recently from cf05709 to 0120551 Compare May 19, 2022 12:52
@Betree Betree force-pushed the debt/sequelize-ts-attributes branch 5 times, most recently from 511f05a to 39645b2 Compare May 25, 2022 11:46
@Betree Betree force-pushed the debt/sequelize-ts-attributes branch 3 times, most recently from 2b798c4 to 9003357 Compare June 13, 2022 07:49
@Betree Betree changed the title Typescript: Move sequelize model attributes to declare Typescript: Move more sequelize model attributes to declare Aug 17, 2022
@Betree Betree force-pushed the debt/sequelize-ts-attributes branch 4 times, most recently from 15719b1 to cf9ed44 Compare August 23, 2022 10:09
@Betree Betree force-pushed the debt/sequelize-ts-attributes branch from cf9ed44 to 7974f8e Compare August 23, 2022 13:18
@Betree Betree marked this pull request as ready for review August 23, 2022 21:23
@Betree Betree merged commit 544ce69 into main Aug 24, 2022
@Betree Betree deleted the debt/sequelize-ts-attributes branch August 24, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new Typescript helpers in sequelize models Sequelize Warnings with ExpenseItem and PayoutMethod
1 participant