chore: update handlebars to version 4.7.1 #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolariin
force-pushed
the
update-handlebars
branch
from
73894e3
to
e3106c7
Compare
|
@Betree could you have a look at this? |
Betree
reviewed
Apr 17, 2020
server/models/User.js
Outdated
| @@ -198,6 +198,7 @@ export default (Sequelize, DataTypes) => { | |||
| emailWaitingForValidation: this.emailWaitingForValidation, | |||
| createdAt: this.createdAt, | |||
| updatedAt: this.updatedAt, | |||
| emailConfirmationToken: this.emailConfirmationToken, | |||
There was a problem hiding this comment.
This is a private information that should never be shared, it should not appear in info.
Because there's only one email relying on that, I would suggest passing it manually where it's needed.
bolariin
force-pushed
the
update-handlebars
branch
2 times, most recently
from
f5f2752
to
187a143
Compare
bolariin
force-pushed
the
update-handlebars
branch
from
187a143
to
1d509a0
Compare
|
@bolariin changes are good. I still need to test the emails, I'll try to do it today. |
|
Sorry for the late update, busy week! Testing that now. |
znarf
approved these changes
Apr 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves opencollective/opencollective#2802
I made use of
infoingetterMethodsof the model as it was already used within the codebase. From what I could see the errors came from passing the sequelize instances directly as data.