enhancement(Expense): reduce default permissions for collective admins #10086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Betree
force-pushed
the
enhancement/expense-permissions-comeback
branch
3 times, most recently
from
34a2faf
to
b2f3654
Compare
Betree
force-pushed
the
enhancement/expense-permissions-comeback
branch
from
b2f3654
to
176f0c0
Compare
Betree
commented
May 7, 2024
Comment on lines
+184
to
+186
| } else if (expense.HostCollectiveId) { | ||
| return req.remoteUser.isAdmin(expense.HostCollectiveId); | ||
| } else if (!expense.collective) { |
There was a problem hiding this comment.
Small, kind of unrelated change here: we're relying on the expense HostCollectiveId rather than the current host to check if the remote user is an admin of the expense's host.
| @@ -689,10 +689,8 @@ describe('server/graphql/v2/mutation/ExpenseMutations', () => { | |||
| }); | |||
|
|
|||
| it('record a breakdown of the values by role (when editing multiple fields)', async () => { | |||
| const collectiveAdmin = await fakeUser(); | |||
There was a problem hiding this comment.
Add to remove that since collective admins cannot edit expenses anymore
znarf
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new try at #8731
Resolve opencollective/opencollective#4729