Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Transactions model to typescript class #10081

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

znarf
Copy link
Member

@znarf znarf commented May 3, 2024

Similar to #10066

MemberInvitation.ts, PaymentMethod.ts and Subscription.ts left todo

@znarf znarf force-pushed the transactions-typescript branch from baa2a95 to 3b728d6 Compare May 3, 2024 10:22
@znarf znarf force-pushed the transactions-typescript branch from 3b728d6 to 4c1c996 Compare May 6, 2024 06:55
@znarf znarf requested a review from Betree May 6, 2024 07:57
Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit difficult to review the diff but the pattern looks ok to me

@znarf znarf merged commit a463dff into main May 15, 2024
19 checks passed
@znarf znarf deleted the transactions-typescript branch May 15, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants