-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to payment processor dashboard #10048
Conversation
2c90bbb
to
261eec9
Compare
70ebfd2
to
0be0eef
Compare
25243e1
to
0c3c71a
Compare
await queryInterface.sequelize.query(` | ||
CREATE INDEX CONCURRENTLY IF NOT EXISTS "orders_isPendingContribution" ON "Orders" (((data #>> '{isPendingContribution}')::text)) where ((data #>> '{isPendingContribution}'::text[]) = 'true'::text); | ||
`); | ||
|
||
await queryInterface.sequelize.query(` | ||
CREATE INDEX CONCURRENTLY IF NOT EXISTS "orders_isManualContribution" ON "Orders" (((data #>> '{isManualContribution}')::text)) where ((data #>> '{isManualContribution}'::text[]) = 'true'::text); | ||
`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we need those casts since the double >>
already casts to text. Also, I think the second cast is wrong, it is not an array of texts.
If you need an example of how to index data fields:
https://github.com/opencollective/opencollective-api/pull/10037/files#diff-3af06b8af92da31930b6a5d8634d7dcca72dfe3d1703564986697d827cc82d78R8-R12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will double check the indexes with the example you provided. The ::text[]
cast refers to the argument of #>>
, but its probably unnecessary, I just copied the database format after creating the index manually.
@@ -280,6 +286,8 @@ export const paymentIntentProcessing = async (event: Stripe.Event) => { | |||
}, | |||
{ transaction }, | |||
); | |||
|
|||
sendEmailNotifications(order); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The processing webhook was not sending a notification or creating an activity for the processing status.
Related opencollective/opencollective#7345
Provides a link to the payment processor dashboard (Stripe) if available.