Improve Assetmanager multi store behavior #5857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PR opencast#4955, Assetmanager supports multiple stores. Moving a mediapackage to different store can result in an AssetManagerException like this: `An asset with checksum … (md5) has already been archived but trying to copy or link asset StoragePath(orgId=mh_default_org, mpId=…, version=…, mpeId=…) to it failed` This is because the path to the mediapackage is cached in the Assetmanager for 60 minutes. That's too long. Reducing the period to 1 minute is enough to get performance boost and be dynamic. Assetmanager decides which asset store to use for each snapshot. That's not the best way. If you have a snapshot in store A and you create another snapshot, the second one may go to store B. This means that hardlinking between the two asset stores may not work and the files will be copied. This patch changes this behavior. All snapshots of a mediapackage are stored in the same asset store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PR #4955, Assetmanager supports multiple stores. Moving a mediapackage to different store can result in an AssetManagerException like this:
An asset with checksum … (md5) has already been archived but trying to copy or link asset StoragePath(orgId=mh_default_org, mpId=…, version=…, mpeId=…) to it failedThis is because the path to the mediapackage is cached in the Assetmanager for 60 minutes. That's too long. Reducing the period to 1 minute is enough to get performance boost and be dynamic.Assetmanager decides which asset store to use for each snapshot. That's not the best way. If you have a snapshot in store A and you create another snapshot, the second one may go to store B. This means that hardlinking between the two asset stores may not work and the files will be copied. This patch changes this behavior. All snapshots of a mediapackage are stored in the same asset store.
Your pull request should…