Fixed bug: tag-engage workflow failes when event is not published #5855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatrinIhler
requested changes
May 15, 2024
| @@ -134,7 +134,8 @@ public WorkflowOperationResult start(WorkflowInstance instance, JobContext conte | |||
| try { | |||
| mediaPackageForSearch = searchService.get(mediaPackageId); | |||
| } catch (NotFoundException | UnauthorizedException e) { | |||
| throw new WorkflowOperationException(e); | |||
| logger.info("No tag engage workflow found for {}", mediaPackageId); | |||
There was a problem hiding this comment.
That logging message isn't quite correct: I'd write something like "Media package {} isn't published to Engage, skipping." Because the workflow does exist, and so does the media package, but not in the SearchService/Engage.
KatrinIhler
requested changes
May 24, 2024
| @@ -134,7 +134,8 @@ public WorkflowOperationResult start(WorkflowInstance instance, JobContext conte | |||
| try { | |||
| mediaPackageForSearch = searchService.get(mediaPackageId); | |||
| } catch (NotFoundException | UnauthorizedException e) { | |||
| throw new WorkflowOperationException(e); | |||
| logger.info("Media package {} is not published to Engage, skipping", mediaPackageId); | |||
There was a problem hiding this comment.
Just realized that we should only skip on NotFound, and fail on Unauthorized. Sorry... 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug that the tag-engage workflow failed when trying to add or remove the video365 tag for an unpublished event. Now the workflow is skipped when the event has not been published yet.