Remove series ACL file from workspaces #5840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On series ACL update all events of the series will be updated too. This results in a event handler call, where the series ACL should be written to the workspace for snapshotting. But the file will never be deleted. This patch fixes that.
| workspace.delete(mpAclAttachmentTuple.getB().getURI()); | ||
| } catch (Exception ex) { | ||
| // We only want to clean up. If the file is gone, that is fine too. | ||
| logger.debug("Unable to delete series acl attachment for media package {} after updating it.", |
There was a problem hiding this comment.
Why not use IOUtils.deleteQuietly? If we don't care that the file is gone, we shouldn't be logging a stack trace, even at debug.
There was a problem hiding this comment.
I agree with the log message.
We can't use IOUtils.deleteQuietly because mpAclAttachmentTuple contains the URL to the file in workspace (e.g. https://…) and not a file path on local storage.
gregorydlogan
approved these changes
May 15, 2024
|
Yes, the june release will be the last one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On series ACL update all events of the series will be updated too. This results in a event handler call, where the series ACL should be written to the workspace for snapshotting. But the file will never be deleted. This patch fixes that.
This patch is successfully tested in production for some semesters.
Your pull request should…