Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vsock cli param #8

Merged
merged 1 commit into from Nov 15, 2022
Merged

Add vsock cli param #8

merged 1 commit into from Nov 15, 2022

Conversation

ananos
Copy link
Contributor

@ananos ananos commented Nov 10, 2022

Using an extra CLI parameter, we are able to specify a unix socket to be used as a VSOCK endpoint for Guest-to-Host communication.

For now, the argument is just the socket path, with a hardcoded Guest ID. The default value is empty so that the VSOCK endpoint is not added by default.

Example invocation:

./dbs-cli --kernel-path ./vmlinux
--rootfs ./rootfs.img
--boot-args 'console=ttyS0 tty0 pci=off root=/dev/vda'
--vsock vsock.sock

Signed-off-by: Anastassios Nanos ananos@nubificus.co.uk

@wllenyj
Copy link
Contributor

wllenyj commented Nov 11, 2022

Thanks for your work.
The project is just getting started, any features are welcome.

Please fix the fmt failure.

I will update the clap version to fix Deny failed.
clap-rs/clap#4422

@ananos
Copy link
Contributor Author

ananos commented Nov 11, 2022

Thanks for your work. The project is just getting started, any features are welcome.

awesome!

Please fix the fmt failure.
I will update the clap version to fix Deny failed. clap-rs/clap#4422

ack -- I'll rebase & push once you merge the clap version update

@wllenyj
Copy link
Contributor

wllenyj commented Nov 14, 2022

Hi, @ananos
#9 has been merged. You can do rebase.

Using an extra CLI parameter, we are able to specify a unix socket
to be used as a VSOCK endpoint for Guest-to-Host communication.

For now, the argument is just the socket path, with a hardcoded
Guest ID. The default value is empty so that the VSOCK endpoint
is not added by default.

Example invocation:

./dbs-cli --kernel-path ./vmlinux \
	  --rootfs ./rootfs.img \
	  --boot-args 'console=ttyS0 tty0 pci=off root=/dev/vda' \
	  --vsock vsock.sock

Signed-off-by: Anastassios Nanos <ananos@nubificus.co.uk>
@ananos
Copy link
Contributor Author

ananos commented Nov 14, 2022

Hi, @ananos #9 has been merged. You can do rebase.

thanks! so, I pushed the rebased branch -- tried with 1.62.1, seems to work fine.

@wllenyj wllenyj merged commit 554c7bd into openanolis:main Nov 15, 2022
@ananos ananos deleted the feat_vsock_param branch November 15, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants