Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update frozen_lake docs #2619

Merged
merged 2 commits into from Feb 17, 2022
Merged

update frozen_lake docs #2619

merged 2 commits into from Feb 17, 2022

Conversation

Arcify
Copy link
Contributor

@Arcify Arcify commented Feb 16, 2022

#2618 Changed env.make version to v1 and made some other small improvements to the documentation to make it more understandable.

I am however, not sure what to change in version info, as v0 (the only version before this one) is already mentioned in the version history.

@Arcify
Copy link
Contributor Author

Arcify commented Feb 16, 2022

Please let me know if there is anything else that is unclear/missing, I would be happy to modify the pull request :)

@trigaten
Copy link
Contributor

trigaten commented Feb 17, 2022

Please let me know if there is anything else that is unclear/missing, I would be happy to modify the pull request :)

Can you add what changed in v1?

Other envs do: http://www.gymlibrary.ml/pages/environments/classic_control/acrobot

@Arcify
Copy link
Contributor Author

Arcify commented Feb 17, 2022

Please let me know if there is anything else that is unclear/missing, I would be happy to modify the pull request :)

Can you add what changed in v1?

Other envs do: http://www.gymlibrary.ml/pages/environments/classic_control/acrobot

The only change I could find to v1 is a few bug fixes in the rewards:
https://github.com/openai/gym/releases (0.19)
#2205

I have added this to my pull requested

@trigaten
Copy link
Contributor

LGTM

@jkterry1
Copy link
Collaborator

I'm merging this so it's in the docs string for the release, please create another PR for any addition changes agreed upon

@jkterry1 jkterry1 merged commit 2c0358b into openai:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants