Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix to ImageEncoder capture_frame #2125

Closed
wants to merge 1 commit into from
Closed

Minor fix to ImageEncoder capture_frame #2125

wants to merge 1 commit into from

Conversation

mattvlaw
Copy link

ImageEncoder was not writing frames in the capture_frame function.
Unindented the call to write a frame in line 303 of video_recorder.py so that it is reachable.

@mattvlaw mattvlaw mentioned this pull request Dec 11, 2020
Closed
casio12r
casio12r approved these changes Dec 17, 2020
View reviewed changes
Copy link

@casio12r casio12r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the same issue too. Without this change, the saved mp4 videos are empty.

@japonophile japonophile mentioned this pull request Jan 3, 2021
Closed
@mattvlaw
Copy link
Author

Fixed in #2139

@mattvlaw mattvlaw closed this Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japonophile japonophile japonophile approved these changes

@casio12r casio12r casio12r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattvlaw @japonophile @casio12r