Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tuple input on MultiBinary space #2023

Merged
merged 3 commits into from Sep 25, 2020
Merged

Add support for tuple input on MultiBinary space #2023

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0483f9
Add support for tuple input on MultiBinary space
lsylusiyao Aug 12, 2020
9864a75
Change input of multibinary
lsylusiyao Aug 16, 2020
88f115b
Remove check of length != 1; Add shape check
lsylusiyao Aug 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions gym/spaces/multi_binary.py
View file
Open in desktop
Expand Up @@ -20,7 +20,12 @@ class MultiBinary(Space):

def __init__(self, n):
self.n = n
super(MultiBinary, self).__init__((self.n,), np.int8)
if (type(n) in [tuple, list] and len(n) != 1) \
or (type(n) is np.ndarray and len(n.shape) != 1):
input_n = n
else:
input_n = (n, )
super(MultiBinary, self).__init__(input_n, np.int8)

def sample(self):
return self.np_random.randint(low=0, high=2, size=self.n, dtype=self.dtype)
Expand All @@ -32,7 +37,7 @@ def contains(self, x):

def to_jsonable(self, sample_n):
return np.array(sample_n).tolist()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the spaces

def from_jsonable(self, sample_n):
return [np.asarray(sample) for sample in sample_n]

Expand Down