Improve the Debian/Ubuntu instructions for adding the OBS repository #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running wget with sudo sounds a little ill-advised. |
|
Oops 😅 I was using However, I've decided against it in the end. Is there anything else that's troubling the definitive reviewer of this that I should fix? Or is this okay code-wise? |
|
I'm not an expert on dpkg/apt, so this looks fine to me otherwise |
|
Uumm ... how can I move this PR forward? 😕 |
I has come to my attention that the `apt-key` practice (as well as the `trusted.gpg.d`) are not recommended by the Debian team (https://wiki.debian.org/DebianRepository/UseThirdParty#OpenPGP_Key_distribution), and instead `deb [ signed-by=... ]` is the recommended practice. I cannot find an official source on why is that in "nice terms", but this article https://michael-prokop.at/blog/2021/02/16/how-to-properly-use-3rd-party-debian-repository-signing-keys-with-apt/ gives more insight into the issue. Additionally, for Ubuntu `wget` > `curl`, since `curl` needs to be installed separately. The issue described in the `h6` above is still "relatively true", but it's less severe. Tested in a home-brewed test, based on the https://software.opensuse.org/download.html?project=home:vtrefny&package=blivet-gui instructions, inside an Ubuntu docker container (with the necessary setup). Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Oops 😅 `gpg --dearmor` is a little bit unnecessary on nowadays `SecureApt`. However, let's not change this to preserve backwards-compatibility instead. Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
hennevogel
force-pushed
the
fix/ubuntu-debian-instructions
branch
from
29758d7
to
2847d86
Compare
|
Is there a reason why you chose a different location ('/usr/share/keychain') for the key than in the article? It seems to me like '/usr/share/keyrings' has become the de-facto standard. |
Oops, typo. Good catch though. ... when Maintainers decide to notice me, I'll do the update |
stdedos
commented
Dec 8, 2023
| @@ -61,7 +61,7 @@ pacman -Sy <%= repo_name %>/<%= @package %></pre> | |||
| <pre><%= | |||
| # don't use apt-add-repository wrapper for Ubuntu for now, because it adds source repo which we don't provide | |||
| # "apt-add-repository deb #{v[:repo]} /\napt-get update\napt-get install #{@package}" | |||
| "echo 'deb #{v[:repo].gsub(/(\w):(\w)/, '\1:/\2').gsub(/^https/, 'http')} /' | sudo tee /etc/apt/sources.list.d/#{@project}.list\ncurl -fsSL #{v[:repo]}Release.key | gpg --dearmor | sudo tee /etc/apt/trusted.gpg.d/#{@project.gsub(':', '_')}.gpg > /dev/null\nsudo apt update\nsudo apt install #{@package}" | |||
| "echo 'deb [ signed-by=/usr/share/keychain/#{@project.gsub(':', '_')}.gpg ] #{v[:repo].gsub(/(\w):(\w)/, '\1:/\2').gsub(/^https/, 'http')} /' | sudo tee /etc/apt/sources.list.d/#{@project}.list\nwget #{v[:repo]}Release.key -O - | gpg --dearmor | sudo tee /usr/share/keychain/#{@project.gsub(':', '_')}.gpg > /dev/null\nsudo apt update\nsudo apt install #{@package}" | |||
There was a problem hiding this comment.
Suggested change
| "echo 'deb [ signed-by=/usr/share/keychain/#{@project.gsub(':', '_')}.gpg ] #{v[:repo].gsub(/(\w):(\w)/, '\1:/\2').gsub(/^https/, 'http')} /' | sudo tee /etc/apt/sources.list.d/#{@project}.list\nwget #{v[:repo]}Release.key -O - | gpg --dearmor | sudo tee /usr/share/keychain/#{@project.gsub(':', '_')}.gpg > /dev/null\nsudo apt update\nsudo apt install #{@package}" | |
| "echo 'deb [ signed-by=/usr/share/keychain/#{@project.gsub(':', '_')}.gpg ] #{v[:repo].gsub(/(\w):(\w)/, '\1:/\2').gsub(/^https/, 'http')} /' | sudo tee /etc/apt/sources.list.d/#{@project}.list\nwget #{v[:repo]}Release.key -O - | gpg --dearmor | sudo tee /usr/share/keyrings/#{@project.gsub(':', '_')}.gpg > /dev/null\nsudo apt update\nsudo apt install #{@package}" |
If the MR moves forward
There was a problem hiding this comment.
The path appears twice and you only changed one. 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I has come to my attention that the
apt-keypractice(as well as the
trusted.gpg.d) are not recommended by the Debian team(https://wiki.debian.org/DebianRepository/UseThirdParty#OpenPGP_Key_distribution),
and instead
deb [ signed-by=... ]is the recommended practice.I cannot find an official source on why is that in "nice terms", but this article
https://michael-prokop.at/blog/2021/02/16/how-to-properly-use-3rd-party-debian-repository-signing-keys-with-apt/
gives more insight into the issue.
Additionally, for Ubuntu
wget>curl, sincecurlneeds to be installed separately.The issue described in the
h6above is still "relatively true", but it's less severe.Tested in a home-brewed test, based on the
https://software.opensuse.org/download.html?project=home:vtrefny&package=blivet-gui
instructions, inside an Ubuntu docker container (with the necessary setup).
Signed-off-by: Stavros Ntentos 133706+stdedos@users.noreply.github.com
Fixes #981 (partially?)