[src/api] Update rubocop: 0.87.1 → 0.88.0 (major) #9914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
depfu
bot
changed the title
depfu
bot
force-pushed
the
depfu/update/srcapi/rubocop-0.88.0
branch
from
5956a9e
to
d5edda8
Compare
Codecov Report
@@ Coverage Diff @@
## master #9914 +/- ##
==========================================
- Coverage 90.53% 90.51% -0.03%
==========================================
Files 565 565
Lines 21264 21244 -20
==========================================
- Hits 19251 19228 -23
- Misses 2013 2016 +3 |
After upgrading the rubocop gem version from 0.87.1 to 0.88.0 the following new cop got introduced and autocorrected: * Style/ArrayCoercion * Style/CaseLikeIf * Style/HashAsLastArrayItem * Style/RedundantFileExtensionInRequire
This fixes the `Style/HashLikeCase` cop which got introduced after the rubocop gem update from version 0.87.1 to 0.88.0
The autocorrection for this part of the code introduced changes in the behaviour of it. Therefore we ignore the cop here, and keep the code as it is.
Address Style/CaseLikeIf cop and move logic from view to a helper method (addressing a FIXME comment).
krauselukas
force-pushed
the
depfu/update/srcapi/rubocop-0.88.0
branch
from
876d92c
to
48b8cc4
Compare
The rubocop autocorrect for Style/CaseLikeIf does not take into account the match operator for regex, which in this case returns the matched data when using it with and if/elsif statement. After just moving this to an case statement, the data is not returned anymore. This could be fixed by using the `$LAST_MATCH_INFO` pseudo variable which contains the whole `MatchData` object of the latest regex matching group.
krauselukas
force-pushed
the
depfu/update/srcapi/rubocop-0.88.0
branch
from
48b8cc4
to
6909ea7
Compare
danidoni
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (0.87.1 → 0.88.0) · Repo · Changelog
Release Notes
0.88.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 68 commits:
Cut 0.88Add a changelog entryIgnore configuration files outside of the projectOnly look up to the project's root for exclusionsFix `traverse_files_upwards` to make searching up to the root possibleMerge pull request #8279 from Fatsoma/feature/require_order_block_passMerge branch 'master' into feature/require_order_block_passFix line number for empty file offenseFix expect_offense when annotations missingMerge pull request #8316 from fatkodima/autocorrect-to-disjunctive_assignment_in_constructorSupport autocorrect for `Lint/DisjunctiveAssignmentInConstructor` copAdd `--memory` option to `bin/rubocop-profile` (#8318)Reuse `ConfigStore#for_pwd` in a couple more placesExtract `ConfigStore#for_pwd`Merge pull request #8315 from eugeneius/percent_literal_delimiters_scrubHandle invalid characters in Style/PercentLiteralDelimitersMerge pull request #8313 from koic/prevent_missing_trailing_zero_in_float_typePrevent missing final zero of version number for docs/antora.ymlOptimize `Lint/DuplicateMethods`, `Lint/NestedMethodDefinition`, `Style/AutoResourceCleanup` and `Style/NumericPredicate` cops a bitMerge pull request #8310 from eugeneius/required_major_ruby_versionHandle major version requirements in Gemspec/RequiredRubyVersionRewrite `Style/TrailingMethodEndStatement` to make it fasterReduce allocated SetsFix LiteralAsCondition when conditionRefactor Lint specs to use expect_offenseReduce memory usage in `ResultCache#rubocop_checksum`Optimize `Style/CommentedKeyword` to reduce memory usageMemoize `Badge#to_s` to reduce memory allocations (#8306)[Docs] Tweak some markup[Docs] Fix a typo[Docs] Remove mention of BountysourceRefactor spec use expect_correction in Lint cops (#8285)[Fixes #8286] Allow abbreviated offense messages with `expect_offense`Rewrite `Layout/SpaceAroundMethodCallOperator` cop to make it fasterMerge pull request #8292 from tejasbubane/fix-8289Remove `PathUtil.pwd` and `PathUtil.chdir`Remove a redundant changelog entryAdd `of` to `AllowedNames` of `MethodParameterName` copSort `AllowedNames` of `MethodParameterName` cop[Fix #8189] Consider spaces for Layout/MultilineBlockLayoutFix `Style/AccessorGrouping` to not register offense for accessor with commentJoin lines because the line length limit is now higherSwith to opposite style since it's preferredRefactor `last_file_upwards` to not build an intermmediate arraySmall file finding refactorAdd new `Style/ArrayCoercion` copAdd new `Lint/DuplicateElsifCondition` copMerge pull request #8287 from tejasbubane/fix-8282Fix `Style/IfUnlessModifier` bad precedence detectionAdd new `Style/CaseLikeIf` copAdd new `Style/RedundantFileExtensionInRequire` copAdd new `Style/HashLikeCase` copMove a couple of changelog entries[Fix #7776] Generate valid code if comment exists before closing brace (#8237)Merge pull request #8271 from fatkodima/hash-array-last-item[Fixes #8273] Fix false positive for Style/WhileUntilModifier.Add new `Style/HashAsLastArrayItem` copUse expect_correction in Lint/NonDeterministicRequireOrder specDetect require method as arg in Lint/NonDeterministicRequireOrderRefactorexpect_offense: coerce replacements to stringRemove unneeded includeRemove unnecessary logic from MissingElse[Fix #8232] Fix a false positive for `Layout/EmptyLinesAroundAccessModifier`Runner: refactorUpdate index.adocBasic support for profiling with bin/rubocop-profile[Docs] Switch back to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands