[src/api] Update rubocop: 0.66.0 → 0.67.2 (major)

[depfu]

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (0.66.0 → 0.67.2) · Repo · Changelog

Release Notes

0.67.2

Bug fixes

• #6882: Fix an error for Rails/RedundantAllowNil when not using both allow_nil and allow_blank. (@koic)

0.67.1

Changes

• #6881: Set default PreferredName to e for Naming/RescuedExceptionsVariableName. (@koic)

0.67.0

New features

• #5184: Add new multiline element line break cops. (@maxh)
• Add new cop Rails/ActiveRecordOverride that checks for overriding Active Record methods instead of using callbacks. (@elebow)
• Add new cop Rails/RedundantAllowNil that checks for cases when allow_blank makes allow_nil unnecessary in model validations. (@elebow)
• Add new Naming/RescuedExceptionsVariableName cop. (@AdrienSldy)

Bug fixes

• #6761: Make Naming/UncommunicativeMethodParamName account for param names prefixed with underscores. (@thomthom)
• #6855: Fix an exception in Rails/RedundantReceiverInWithOptions when the body is empty. (@ericsullivan)
• #6856: Fix auto-correction for Style/BlockComments when the file is missing a trailing blank line. (@ericsullivan)
• #6858: Fix an incorrect auto-correct for Lint/ToJSON when there are no to_json arguments. (@koic)
• #6865: Fix deactivated StyleGuideBaseURL for Layout/ClassStructure. (@aeroastro)
• #6868: Fix Rails/LinkToBlank auto-correct bug when using symbol for target. (@r7kamura)
• #6869: Fix false positive for Rails/LinkToBlank when rel is a symbol value. (@r7kamura)
• Add IncludedMacros param to default rubocop config for Style/MethodCallWithArgsParentheses. (@maxh)
• #6785: Do not register an offense for Rails/Present or Rails/Blank in an unless else context when Style/UnlessElse is enabled. (@rrosenblum)

Changes

• #6854: Mark Rails/LexicallyScopedActionFilter as unsafe and document risks. (@urbanautomaton)
• #5977: Warn for Performance Cops. (@koic)
• #6637: Move LstripRstrip from Performance to Style department and rename it to Strip. (@anuja-joshi)
• #6875: Mention block form of Struct.new in Style/StructInheritance. (@XrXr)
• #6871: Move Performance/RedundantSortBy, Performance/UnneededSort and Performance/Sample to the Style department. (@bbatsov)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 41 commits:

• Cut 0.67.2
• Fix a typo
• [Fix #6882] Fix an error for `Rails/RedundantAllowNil`
• Cut 0.67.1
• Set default `PreferredName` to `e` for `Naming/RescuedExceptionsVariableName`
• Cut 0.67
• Fix the manual
• Add new Naming/RescuedExceptionsVariableName cop
• [Fix #6785] Make Rails/Blank and Rails/Present aware of Style/UnlessElse
• Update a bit of cop metadata
• [Fix #5184] Add new multiline element line break cops (#6824)
• Add `STDERR.puts` check to Style/StderrPuts cop
• [Fix #6871] Move several performance cops to the style department
• Insert a newline at EOF of CHANGELOG.md
• Mention block form of Struct.new in Style/StructInheritance (#6875)
• Add IncludedMacros param to default rubocop config for MethodCallWithArgsParentheses
• Mark Rails/LexicallyScopedActionFilter as unsafe
• Clarify dangers of Rails/LexicallyScopedActionFilter
• Add new cop `Rails/ActiveRecordOverride`
• NodePattern: Allow numerals in identifiers
• [Fix #6761] Make UncommunicativeMethodParamName account for underscores (#6872)
• Add `Rails/RedundantAllowNil` cop
• Fix false positive for `Rails/LinkToBlank` when rel is a symbol value
• Merge pull request #6874 from koic/rename_files_for_style_strip
• Rename files for `Style/Strip` cop
• Rename Style/LstripRstrip to Style/Strip
• [Fix #6637] promoted Performance/LstripRstrip to Style/LstripRstrip
• Fix Rails/LinkToBlank auto-correct bug when using symbol for target
• [User Manual] Alphabetize CLI options (#6867)
• Merge pull request #6865 from aeroastro/feature/remove-preceding-prefix
• Fix deactivated `StyleGuideBaseURL` for `Layout/ClassStructure`
• Merge pull request #6859 from koic/fix_incorrect_autocorrect_for_lint_to_json
• [Fix #6858] Fix an incorrect auto-correct for `Lint/ToJSON`
• Merge pull request #6856 from annkissam/handle_exception_in_block_comments
• handle autocorrect exception in Style/BlockComments
• handle exception in Rails/RedundantReceiverInWithOptions with empty body (#6855)
• Merge pull request #6852 from iliabylich/use-absolute-path-to-gemfile-lock
• Merge pull request #6851 from marcandre/type_pattern
• Use absolute path to Gemfile.local in Gemfile.
• Fix NodePattern of node type on a literal
• [#5977] Warn for Performance Cops

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)

[DavidKang]

@depfu rebase

[coolo]

the crash looks like a rubocop bug - we run rake under bundler, but don't have a Gemfile.lock in root directory. That's causing the crash

[coolo]

rubocop/rubocop#6917

[coolo]

There is another bug with this update: rubocop/rubocop#6888 affecting all our activemodel classes. Not a good version