-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Notification scopes #16147
Refactor Notification scopes #16147
Conversation
44295a7
to
386c124
Compare
94647f9
to
c241b77
Compare
Review app will appear here: http://obs-reviewlab.opensuse.org/hennevogel-refactoringnotification-scopes |
d07d6eb
to
da9dad6
Compare
da9dad6
to
d5578d7
Compare
879adab
to
da9dad6
Compare
This will be the foundation where we'll build a better openSUSE#16101. We decouple the read/unread status of a notification from it's type (which notifiable it associated to).
da9dad6
to
35eccdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to push another commit to fix the button text that is displayed "Mark selected as 'Read'"
when we are in the Read list.
In other words: I'm going to adapt the NotificationActionBarComponent.
Instead of type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Show more/less is not working properly either. Trying to fix it...
a6ac2f4
to
479594a
Compare
This will be the foundation where we'll build a better #16101.
We decouple the read/unread status of a notification from it's
type (which notifiable it associated to).