Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Notification scopes #16147

Merged
merged 4 commits into from
May 23, 2024

Conversation

hennevogel
Copy link
Member

@hennevogel hennevogel commented May 16, 2024

This will be the foundation where we'll build a better #16101.

We decouple the read/unread status of a notification from it's
type (which notifiable it associated to).

@hennevogel hennevogel marked this pull request as draft May 16, 2024 13:34
@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label May 16, 2024
@hennevogel hennevogel changed the title WIP Refactor Notification scopes May 16, 2024
@hennevogel hennevogel force-pushed the refactoring/notification-scopes branch 3 times, most recently from 44295a7 to 386c124 Compare May 16, 2024 15:22
@danidoni danidoni force-pushed the refactoring/notification-scopes branch 3 times, most recently from 94647f9 to c241b77 Compare May 20, 2024 06:11
@danidoni danidoni marked this pull request as ready for review May 20, 2024 06:38
@ncounter ncounter added the review-app Apply this label if you want a review app started label May 20, 2024
@obs-bot
Copy link
Collaborator

obs-bot commented May 20, 2024

@danidoni danidoni force-pushed the refactoring/notification-scopes branch 2 times, most recently from d07d6eb to da9dad6 Compare May 21, 2024 16:17
@ncounter ncounter force-pushed the refactoring/notification-scopes branch from da9dad6 to d5578d7 Compare May 22, 2024 10:32
@danidoni danidoni force-pushed the refactoring/notification-scopes branch from 879adab to da9dad6 Compare May 22, 2024 11:00
This will be the foundation where we'll build a better openSUSE#16101.

We decouple the read/unread status of a notification from it's
type (which notifiable it associated to).
@ncounter ncounter force-pushed the refactoring/notification-scopes branch from da9dad6 to 35eccdb Compare May 22, 2024 11:10
Copy link
Contributor

@saraycp saraycp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to push another commit to fix the button text that is displayed "Mark selected as 'Read'" when we are in the Read list.

In other words: I'm going to adapt the NotificationActionBarComponent.

Copy link
Contributor

@saraycp saraycp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show more/less is not working properly either. Trying to fix it...

@saraycp saraycp force-pushed the refactoring/notification-scopes branch from a6ac2f4 to 479594a Compare May 23, 2024 11:08
@ncounter ncounter merged commit c654b55 into openSUSE:master May 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app review-app Apply this label if you want a review app started
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants