Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.10] Update Puma to fix chunked upload failures #13514

Closed
wants to merge 1 commit into from

Conversation

refi64
Copy link

@refi64 refi64 commented Dec 12, 2022

Older verisons of Puma had a bug where chunked uploads would result in an empty body:

puma/puma#1839

This breaks OBS file uploads that rely chunked transfers, which is generally the standard mechanism used by http clients for uploading large files. A fix was backported to 4.3.7:

puma/puma#2496

so this PR updates Puma to the latest 4.3.x release to include this fix.

Likely fixes #9329.

(Note that, if OBS is behind a reverse proxy, this issue may not be observed in the first place, as many reverse proxies will tend to buffer the uploaded data, thus side-stepping the use of chunked uploads entirely.)

Signed-off-by: Ryan Gonzalez ryan.gonzalez@collabora.com

Older verisons of Puma had a bug where chunked uploads would result in
an empty body:

puma/puma#1839

This breaks OBS file uploads that rely chunked transfers, which is
generally the standard mechanism used by http clients for uploading
large files. A fix was backported to 4.3.7:

puma/puma#2496

so this PR updates Puma to the latest 4.3.x release to include this
fix.

Likely fixes openSUSE#9329.

(Note that, if OBS is behind a reverse proxy, this issue may not be
observed in the first place, as many reverse proxies will tend to
buffer the uploaded data, thus side-stepping the use of chunked uploads
entirely.)

Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
@refi64 refi64 force-pushed the wip/refi64/update-puma-upstream branch from ed14514 to 4ecac36 Compare December 12, 2022 17:05
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #13514 (4ecac36) into 2.10 (791531c) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             2.10   #13514   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files         501      501           
  Lines       21234    21234           
=======================================
+ Hits        19275    19276    +1     
+ Misses       1959     1958    -1     

@dmarcoux
Copy link
Contributor

We don't use Puma in production, as you can see the gem is in the development and test groups in

group :development, :test do
gem 'rspec'
# as testing framework
gem 'rspec-rails'
# for fixtures
gem 'factory_bot_rails'
# for mocking the backend
gem 'vcr'
# as alternative to the standard IRB shell
gem 'pry'
# add step-by-step debugging and stack navigation capabilities to pry
gem 'pry-byebug'
# for style checks
gem 'rubocop', require: false
# for rails style checks
gem 'rubocop-rails', require: false
# for rspec style checks
gem 'rubocop-rspec', require: false
# for performance checks
gem 'rubocop-performance'
# integrates with RuboCop to analyse HAML files
gem 'haml_lint'
# to generate random long strings
gem 'faker'
# to launch browser in test
gem 'launchy'
# for calling single testd
gem 'single_test'
# to find n+1 queries
gem 'bullet'
# Use Puma as the app server
gem 'puma'
# to drive headless chrome
gem 'selenium-webdriver'
end

So updating this gem in the 2.10 branch isn't needed.

@dmarcoux dmarcoux closed this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants