Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[src/api] Update rubocop-rails: 2.9.1 → 2.10.1 (minor) #11150

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented May 18, 2021

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.9.1 → 2.10.1) · Repo · Changelog

Release Notes

2.10.1

Bug fixes

  • #478: Fix Rails/ReversibleMigrationMethodDefinition cop's Include. (@rhymes)

2.10.0

New features

Bug fixes

  • #421: Fix incorrect auto-correct for Rails/LinkToBlank when using target: '_blank' with hash brackets for the option. (@koic)
  • #436: Fix a false positive for Rails/ContentTag when the first argument is a splat argument. (@koic)
  • #435: Fix a false negative for Rails/BelongsTo when using belongs_to lambda block with required option. (@koic)
  • #451: Fix a false negative for Rails/RelativeDateConstant when a method is chained after a relative date method. (@koic)
  • #450: Fix a crash for Rails/ContentTag with nested content tags. (@tejasbubane)
  • #103: Fix a false positive for Rails/FindEach when not inheriting ActiveRecord::Base and using all.each. (@koic)
  • #466: Fix a false positive for Rails/DynamicFindBy when not inheriting ApplicationRecord and without no receiver. (@koic)
  • #147: Fix a false positive for Rails/HasManyOrHasOneDependent when specifying default dependent: nil strategy. (@koic)
  • #137: Make Rails/HasManyOrHasOneDependent aware of readonly? is true. (@koic)
  • #474: Fix a false negative for Rails/SafeNavigation when using try! without receiver. (@koic)
  • #126: Fix an incorrect auto-correct for Rails/SafeNavigation with Style/RedndantSelf. (@koic)
  • #476: Fix a false positive for Rails/ReversibleMigration when using drop_table with symbol proc. (@koic)

Changes

  • #409: Deconstruct "table.column" in Rails/WhereNot. (@mobilutz)
  • #416: Make Rails/HasManyOrHasOneDependent accept combination of association extension and with_options. (@ohbarye)
  • #432: Exclude gemspec file by default for Rails/TimeZone cop. (@koic)
  • #440: This PR makes Rails/TimeZone aware of timezone specifier. (@koic)
  • #381: Update IgnoredMethods list for Lint/NumberConversion to allow Rails' duration methods. (@dvandersluis)
  • #444: Mark Rails/Blank as unsafe auto-correction. (@koic)
  • #451: Make Rails/RelativeDateConstant aware of yesterday and tomorrow methods. (@koic)
  • #454: Mark Rails/WhereExists as unsafe auto-correction. (@koic)
  • #403: Mark Rails/WhereEquals as unsafe auto-correction. (@koic)
  • #379: Mark Rails/DynamicFindBy as unsafe. (@koic)
  • #106: Mark Rails/ReflectionClassName as unsafe. (@koic)
  • #106: Make Rails/ReflectionClassName aware of the use of string with to_s. (@koic)
  • #456: Drop Ruby 2.4 support. (@koic)
  • #462: Require RuboCop 1.7 or higher. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu PRs from our dependency update bot label May 18, 2021
@eduardoj
Copy link
Member

@depfu pause

Pausing because rexml dependency has to be solved first.

@depfu
Copy link
Contributor Author

depfu bot commented May 18, 2021

Pausing rubocop-rails updates for all future versions. Go to your Depfu dashboard or use the @depfu resume command to resume updates.

@depfu depfu bot closed this May 18, 2021
@depfu depfu bot deleted the depfu/update/srcapi/rubocop-rails-2.10.1 branch May 18, 2021 11:47
@dmarcoux
Copy link
Contributor

dmarcoux commented Jun 9, 2021

@depfu resume

@depfu
Copy link
Contributor Author

depfu bot commented Jun 9, 2021

Resuming updates for rubocop-rails. New pull requests will be opened when the next version is released.

@dmarcoux dmarcoux restored the depfu/update/srcapi/rubocop-rails-2.10.1 branch June 9, 2021 16:23
@dmarcoux dmarcoux reopened this Jun 9, 2021
@dmarcoux
Copy link
Contributor

dmarcoux commented Jun 9, 2021

@depfu rebase

@depfu depfu bot force-pushed the depfu/update/srcapi/rubocop-rails-2.10.1 branch from 954f7e2 to 752b33f Compare June 9, 2021 18:02
@depfu depfu bot changed the title 🚨 [security] [src/api] Update rubocop-rails: 2.9.1 → 2.10.1 (minor) [src/api] Update rubocop-rails: 2.9.1 → 2.10.1 (minor) Jun 9, 2021
@dmarcoux
Copy link
Contributor

dmarcoux commented Jun 9, 2021

I created an issue upstream regarding the remaining offenses since I just don't get it... it seems to be a false positive.

@vpereira vpereira self-assigned this Jun 10, 2021
@dmarcoux dmarcoux force-pushed the depfu/update/srcapi/rubocop-rails-2.10.1 branch from b081738 to 752b33f Compare June 22, 2021 08:25
@dmarcoux
Copy link
Contributor

@depfu rebase

@depfu depfu bot force-pushed the depfu/update/srcapi/rubocop-rails-2.10.1 branch from 752b33f to 67fc76f Compare June 22, 2021 08:26
@dmarcoux
Copy link
Contributor

dmarcoux commented Jun 22, 2021

@depfu rebase (RuboCop is already updated on master)

@depfu depfu bot force-pushed the depfu/update/srcapi/rubocop-rails-2.10.1 branch from 67fc76f to a5dc6f4 Compare June 22, 2021 09:57
@dmarcoux
Copy link
Contributor

Closed, there's a newer release: #11270

@dmarcoux dmarcoux closed this Jun 22, 2021
@dmarcoux dmarcoux deleted the depfu/update/srcapi/rubocop-rails-2.10.1 branch June 22, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depfu PRs from our dependency update bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants