[src/api] Update rubocop: 1.4.2 → 1.5.2 (minor) #10535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
eduardoj
reviewed
Dec 7, 2020
| @@ -1377,6 +1378,7 @@ Style/OptionalBooleanParameter: | |||
| - 'lib/xpath_engine.rb' | |||
|
|
|||
| # Offense count: 54 | |||
| # Cop supports --auto-correct. | |||
There was a problem hiding this comment.
Trying to fix these offenses with --auto-correct resulted in hitting this issue: rubocop/rubocop#9160
Therefore, we don't correct these offenses with --auto-correct, yet.
Codecov Report
@@ Coverage Diff @@
## master #10535 +/- ##
==========================================
+ Coverage 91.04% 91.08% +0.03%
==========================================
Files 581 581
Lines 21452 21452
==========================================
+ Hits 19532 19539 +7
+ Misses 1920 1913 -7 |
dmarcoux
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (1.4.2 → 1.5.2) · Repo · Changelog
Release Notes
1.5.2
1.5.1
1.5.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 56 commits:
Cut 1.5.2Update Changelog[Fix #9151] Don't suggest extensions that are installed but not direct dependencies.[Fix #9161] Fix a false positive for `Layout/HeredocArgumentClosingParenthesis`Support regexp_parser 1.8 and 2.x series[Fix #9152] Fix an incorrect auto-correct for `Style/SoleNestedConditional`[Fix #9155] Fix a false positive for `Layout/MultilineMethodCallIndentation`Tighten the RuboCop AST dependency (#9158)[Fix #8985] Fix `Style/StringConcatenation` autocorrect generating invalid rubyRelax regexp_parser requirement.[Fix #9080] Make `Lint/ShadowingOuterVariable` aware of `Ractor`Fix the release notes for 1.5.1Switch back the docs versionCut 1.5.1Update Changelog[Fix #9145] Fix issues with SuggestExtensions when bundler is not available, or when there is no gemfile.[Fix #9140] Fix an error for `Layout/EmptyLinesAroundArguments`[Fix #8684] Fix an error for `Lint/InterpolationCheck` copFix rubocop failure introduced in 9a8777fAdd tests and documentation for SuggestExtensionsAllowedIdentifiers now also checks variable assignments (#9136)Fix changelogFix the release notesSwitch back the docs version to masterCut 1.5.0Update Changelog[Fix #9122] Add suggestion if any gems are loaded that have rubocop extensions (#9130)[Docs] Add a section about joining the Core Team[Fixes #8564] `Metrics/AbcSize`: Add optional discount for repeated "attributes"AbcSize calculator: visit children firstRefactorImprove doc[Fix #9128] Fix an incorrect auto-correct for `Style/ClassAndModuleChildren`Small refactor of #9127Fix #8820 autocorrection for Style/IfWithSemicolon[Fix #9124] Update example for `rubocop -V` of issue templateUpdate `Style/SymbolProc` to be aware of numblocks (#9127)Use `Cop::Base` API for several cops[Fix #9095] Use merged_config instead of config for pending new cop check[Fix #9115] Fix a false positive for `Style/FirstArgumentIndentation`Support auto-correction for `Style/SoleNestedConditional`Add new cop `Lint/UnexpectedBlockArity` (#9112)Fix a false positive for `Style/MethodCallWithoutArgsParentheses`Update `Lint/UnmodifiedReduceAccumulator` to handle numblocks and more than 2 arguments.Update `IgnoredMethods` so that every cop that uses it will accept both strings and regexes in the configuration.Update `Metrics/BlockLength` and `Metrics/MethodLength` to use `IgnoredMethods` instead of `ExcludedMethods` in configuration. The previous key is retained for backwards compatibility.[Fix #9105] Fix an incorrect auto-correct for `Style/RedundantCondition`[Fix #9104] Preset some stdlib method names for `Naming/VariableNumber`[Fix #9097] Fix a false positive for `Layout/EmptyLinesAroundArguments``Metrics/ParameterLists` supports `MaxOptionalParameters` config parameterUpdate `ConfigObsoletion` so that parameters can be deprecated but still accepted.Merge pull request #9102 from knu/upgrade_regexp_parserUpgrade regexp_parser to 2.0Add examples to Metrics/ParameterLists[Fix #8053] Fix an incorrect auto-correct for `Style/AndOr`Switch back the docs version to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands