-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce more flexible storeChunk() syntax, use to add ADIOS2 memory selection #1620
Open
franzpoeschel
wants to merge
20
commits into
openPMD:dev
Choose a base branch
from
franzpoeschel:adios2-memory-selection
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
added
backend: ADIOS2
frontend: C++17
frontend: Python3
api: new
additions to the API
labels
May 17, 2024
franzpoeschel
force-pushed
the
adios2-memory-selection
branch
2 times, most recently
from
May 22, 2024 11:44
727cbbc
to
ddcdfc9
Compare
knew there was sth like this
franzpoeschel
force-pushed
the
adios2-memory-selection
branch
from
June 7, 2024 12:41
c05d535
to
ba7c582
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't support memory selections yet, e.g. when you have a 2D memory buffer but want to write only an arbitrary block from it. That block is then non-contiguous, but ADIOS2 has so-called memory selections to support this.
We currently don't have an API that would be able to expose this (except in Python where the native Python buffer protocol is powerful enough to express this; we currently throw an error when detecting this
strides in selection are inefficient, not implemented!
). Since theloadChunk()/storeChunk()
API is somewhat convoluted by now anyway, I didn't want to add even further overloads.Instead, this PR proposes a new syntax for setting up load/store calls:
This API makes it easier to add functionality without going through every single overload and adapting it. Further, it makes the API more consistent, e.g. offset and extent are now always optional and not just for those calls that implement a default logic.
With this PR, the old API calls are now fully implemented via the new API, giving it a good test coverage.
TODO:
.noop_future()
to disable future return types.